5 commits

Author	SHA1	Message	Date
Yves Senn	85261a5e96	remove ancient TODOs [ci skip].	2013-03-18 16:42:08 +01:00
Yves Senn	947e1d5e85	deprecate assert_blank and assert_present. ... They don't add any benefits over `assert object.blank?` and `assert object.present?`	2013-01-05 18:04:52 +01:00
Xavier Noria	fb6b805620	code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them	2010-08-17 03:32:11 +02:00
Yehuda Katz	4cbb9db0a5	For performance reasons, you can no longer call html_safe! on Strings. Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). ... * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe.	2010-01-31 19:39:13 -08:00
Michael Koziarski	9415935902	Switch to on-by-default XSS escaping for rails. ... This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration.	2009-10-08 09:31:20 +13:00