Santiago Pastorino
5fb42ac478
Tests and docs which explain the use of validate with a block and without arguments
2010-12-19 18:50:18 -02:00
Thilo Utke
7148b933c4
ActiveModel::Errors.to_hash returns plain OrderedHash and used in to_json serialization to properly handle multiple errors per attribute [ #5615 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-12-01 11:43:37 +01:00
José Valim
f0ee4a6002
Remove deprecations in ActiveModel.
2010-08-29 20:45:34 -03:00
Neeraj Singh
2ffa50f5a9
after_validation should be called irrespective of the result of validation.
...
I confirmed that this is the behavior on 2.3.x .
[5419 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 11:24:43 -03:00
Santiago Pastorino
b451de0d6d
Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)
2010-08-14 04:12:33 -03:00
Alex Le
aeaab06c79
ActiveModel::Errors json serialization to work as Rails 3b4 [ #5254 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-02 16:26:32 +02:00
José Valim
7bd85a8fc2
Work around the fact the JSON gem was overwriting to_json implementation for all Ruby core classes.
...
This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized.
So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
2010-06-26 12:01:13 +02:00
Josh Kalderimis
e8c064bbe0
Regression with how base errors messages are added to a model. Works correctly for both string error messages and symbol translated messages.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-23 14:45:55 +02:00
Santiago Pastorino
fdfebb7782
Make use of assert_equal to test equallity between object assert expects and object and a message of error
...
[#4611 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-16 16:06:28 +02:00
Josh Kalderimis
9131a88bb8
validation macros can now be used within an instance
2010-05-13 13:57:37 -07:00
Josh Kalderimis
605c6455ac
removed AR from all AMo tests, including any unneeded files (schema, fixtures and test helper)
2010-05-09 00:08:11 +03:00
Josh Kalderimis
88ad3ed8b5
removed an old unused model in the AMo tests which also removes another AR dependency
2010-05-09 00:08:11 +03:00
Josh Kalderimis
66913a76af
removed use of AR in AMo tests and removed testing of scopes (:on) in individual validation tests and moved them to their own test file
2010-05-08 23:51:36 +03:00
Ryan Bigg
d748cc3cd0
Re-define empty? for errors to check if the values inside the OrderedHash are empty rather than the OrderedHash itself. [ #4356 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-04-10 13:21:20 +02:00
Prem Sichanugrist
8f97e9d19a
Add validators reflection so you can do 'Person.validators' and 'Person.validators_on(:name)'.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-02-21 12:37:46 +01:00
Samuel Elliott
31ea83eb89
Adding Proc support to validation messages so that they can become a little more dynamic, allowing for customisations during the request [ #3514 status:resolved].
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-01-17 14:40:10 +01:00
José Valim
5fdd0e80a4
Be sure to convert namespaced names to we have 'Parrots name' instead of 'Parrots.name' in error messages.
2010-01-02 22:27:02 +01:00
José Valim
74098e4cb6
No need to use ValidationsRepairHelper hack on ActiveModel anymore, Model.reset_callbacks(:validate) is enough. However, tests in ActiveRecord are still coupled, so moved ValidationsRepairHelper back there.
2009-12-23 13:30:58 +01:00
Akira Matsuda
0990a13500
Ensure validation errors to be ordered in declared order
...
[#2301 state:committed milestone:2.3.5]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-09-11 18:52:22 -07:00
José Valim
4f37b97033
Changed ActiveRecord to use new callbacks and speed up observers by only notifying events that are actually being consumed.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-09-08 10:26:39 -05:00
James Hill
cfd421daa2
Allow validations to use values from custom readers [ #2936 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-08-05 11:45:01 -05:00
Pratik Naik
320933205e
Deprecate Errors#on_base/add_to_base/invalid?/each_full
2009-03-21 18:34:05 +00:00
Pratik Naik
7d187c193c
Validation tests arent using any fixtures
2009-03-20 18:07:35 +00:00
Pratik Naik
37283a6aae
Deprecate Error#on(attribute) in favour of Errors#[attribute]
2009-03-20 17:36:22 +00:00
Pratik Naik
4367f39dea
TestDatabase -> TestsDatabase
2009-03-20 16:02:12 +00:00
Pratik Naik
60756ad4ec
Move relevant validation tests from Active Record to Active Model
2009-03-20 15:07:49 +00:00
