Eileen Uchitelle
e8c1be4ae7
Add allocations to template renderer subscription
...
This PR adds the allocations to the instrumentation for template and
partial rendering.
Before:
```
Rendering posts/new.html.erb within layouts/application
Rendered posts/_form.html.erb (9.7ms)
Rendered posts/new.html.erb within layouts/application (10.9ms)
Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms)
```
After:
```
Rendering posts/new.html.erb within layouts/application
Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004)
Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654)
Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564)
```
2018-10-10 08:07:12 -04:00
Aaron Patterson
4f96e739c2
Remove deprecated catch-all route in the AV tests
...
This commit removes a deprecated catch-all route in the AV tests. It
defines and includes the necessary routes for each test such that we
don't need the catch-all anymore.
This also helps push us toward #33970
2018-09-24 15:39:15 -07:00
Kir Shatrov
424117281e
Use frozen string literal in actionview/
2017-07-24 11:53:43 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590
, reversing
changes made to afb66a5a59
.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Ryuta Kamizono
b201474756
Should escape meta characters in regexp
2017-05-07 04:10:00 +09:00
Xavier Noria
63fff600ac
modernizes hash syntax in actionview
2016-08-06 19:36:34 +02:00
Xavier Noria
4b6c68dfb8
applies new string literal convention in actionview/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:50:17 +02:00
Rafael Mendonça França
9a1ab66744
Store the old logger before calling super
...
setup in ActiveSupport::LogSubscriber::TestHelper call set_logger that
will change ActionController::Base.logger to the MockLogger so that
logger will be always MockLogger
2016-07-17 05:13:56 -03:00
robertomiranda
ce8efcf296
Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846
...
ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
2015-01-31 23:12:41 -05:00
Rafael Mendonça França
5e6c45a7db
Removed warning
2014-08-18 20:41:03 -03:00
José Valim
2b0c602bc3
Remove usafe of respond_to in ActionView tests
2014-08-17 13:20:22 -04:00
Piotr Sarnacki
eb23754ebb
Move template tests from actionpack to actionview
2013-06-20 17:23:16 +02:00