Ryuta Kamizono
|
c81af6ae72
|
Enable Layout/EmptyLinesAroundAccessModifier cop
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776,
https://github.com/rails/rails/pull/34832#discussion_r244847195).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059).
That cop and enforced style will reduce the our code review cost.
|
2019-06-13 12:00:45 +09:00 |
|
Edgars Beigarts
|
7432c9226e
|
Use weak references in descendants tracker
It allows anonymous subclasses to be garbage collected.
|
2019-03-26 12:11:37 +02:00 |
|
Daniel Colson
|
82c39e1a0b
|
Use assert_empty and assert_not_empty
|
2018-01-25 23:32:59 -05:00 |
|
Daniel Colson
|
94333a4c31
|
Use assert_predicate and assert_not_predicate
|
2018-01-25 23:32:59 -05:00 |
|
Koichi ITO
|
ac717d65a3
|
[Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment
|
2017-07-11 13:12:32 +09:00 |
|
Kir Shatrov
|
72950568dd
|
Use frozen-string-literal in ActiveSupport
|
2017-07-09 15:08:29 +03:00 |
|
Matthew Draper
|
87b3e226d6
|
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
|
2017-07-02 02:15:17 +09:30 |
|
Kir Shatrov
|
cfade1ec7e
|
Enforce frozen string in Rubocop
|
2017-07-01 02:11:03 +03:00 |
|
Akira Matsuda
|
3fe6a5d510
|
Privatize unneededly protected methods in Active Support tests
|
2016-12-24 00:22:29 +09:00 |
|
Xavier Noria
|
80e66cc4d9
|
normalizes indentation and whitespace across the project
|
2016-08-06 20:16:27 +02:00 |
|
Xavier Noria
|
a731125f12
|
applies new string literal convention in activesupport/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
2016-08-06 18:10:53 +02:00 |
|
Aaron Patterson
|
a3ad0a7b67
|
fix assertions
|
2012-10-18 13:14:43 -07:00 |
|
thedarkone
|
9f84e60ac9
|
Make DescendantsTracker thread safe and optimize the #descendants method.
|
2012-10-18 12:08:01 -07:00 |
|
Rolf Timmermans
|
76e4e2fa46
|
Refactored AS::DescendantsTracker test cases so they can be tested without AS::Dependencies.
|
2011-03-13 17:04:01 +01:00 |
|