1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

23 commits

Author SHA1 Message Date
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
bogdanvlviv
40bdbce191
Define path with __dir__
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
2017-05-23 00:53:51 +03:00
Matthew Draper
6c08d480f1 Start Rails 5.2 development 2017-03-22 10:11:39 +10:30
yuuji.yaginuma
08df808b41 Use released arel
Follow up to ea9566f6cd
2017-02-26 19:55:52 +09:00
Rafael Mendonça França
e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
yuuji.yaginuma
3173244d4b remove unnessary session_store setting
Since e5a6f7ee9e, by default the session store
will be set to cookie store with application name as session key.
2016-08-20 20:24:17 +09:00
Xavier Noria
6b3719b757 applies new string literal convention in guides
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:21:59 +02:00
Rafael Mendonça França
454bc1deab Remove github gems from the master bug report templates
All gems are released now so we don't need to ask the github repository
for these gems anymore.
2016-02-18 15:35:45 -02:00
claudiob
9ddd1c4451 Fix: make Travis CI happy about guides again
Tests on Rails [are currently failing](https://travis-ci.org/rails/rails/jobs/78255666).

The reason is the dependency of Rails master from gems that are currently on
GitHub (not on RubyGems) and should be explicitly referenced in the Guides
test files.
2015-09-01 10:00:06 -07:00
Aaron Patterson
7354ef146e argh!!! 2015-08-20 13:55:48 -07:00
yuuji.yaginuma
fec638cf1a use plain option instead of deprecated text option
this will silence deprecation warnings
2015-07-18 17:37:34 +09:00
akihiro17
b07483490f Output an error message and raise an error if bundler 1.10.x is not installed when reporting bugs 2015-06-06 23:09:46 +09:00
Roque Pinel
89550bc1a0 Add the bug report templates to the Travis CI build
The bug report templates are now executed from the `ci/travis.rb` when
`GEM` contains `guides`.

I started by creating a `test` task in `guides/Rakefile` to handle this,
but since inline `gemfile` must not be executed with `bundle exec`, that
rake task would not be consistent with others. So I went back by
executing them directly from `Build`.

Use inline Gemfile dependency when reporting gem bugs
2015-06-05 15:29:48 -05:00
Roque Pinel
ebd806cf4b Use inline Gemfile dependency when reporting bugs
With Bundler `1.10.3`, it is possible to list the gems inline without the
need to create a `Gemfile` if none is found in the current directory.
2015-06-03 22:02:25 -05:00
Rafael Mendonça França
86637391db Remove rack and i18n master from bug report tempaltes [ci skip] 2014-12-19 15:12:31 -02:00
Benjamin Fleischer
db5f1a46f2 secret_token is now saved in Rails.application.secrets.secret_token
- `secrets.secret_token` is now used in all places `config.secret_token` was
  - `secrets.secret_token`, when not present in `config/secrets.yml`,
    now falls back to the value of `config.secret_token`
  - when `secrets.secret_token` is set, it over-writes
    `config.secret_token` so they are the same (for backwards-compatibility)
  - Update docs to reference app.secrets in all places
    - Remove references to `config.secret_token`, `config.secret_key_base`
- Warn that missing secret_key_base is deprecated
- Add tests for secret_token, key_generator, and message_verifier
  - the legacy key generator is used with the message verifier when
    secrets.secret_key_base is blank and secret_token is set
  - app.key_generator raises when neither secrets.secret_key_base nor
    secret_token are set
  - app.env_config    raises when neither secrets.secret_key_base nor
    secret_token are set
- Add changelog

Run focused tests via
ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
2014-11-02 21:21:09 -06:00
yuuji.yaginuma
ea88b8e8c3 [ci skip]Add i18n master to the Gemfile 2014-07-24 17:08:11 +09:00
Abdelkader Boudih
d966ee0eca [Bug report templates] Added rack master to the Gemfile 2014-07-12 10:36:57 +00:00
Abdelkader Boudih
f367f2e50e Add arel to the controller template 2014-07-03 19:35:53 +00:00
Roman Kushnir
299fe844dd Include URL helpers in TestController in bug report templates
[ci skip]

Fixes #12848.
2013-11-11 21:28:26 +02:00
laurocaetano
d48222d22e remove warnings on ruby trunk 2013-11-01 18:15:53 -02:00
Paul Nikitochkin
9d9254f5e0 Added bug report template for ActionController
[ci skip]
2013-08-21 23:26:20 +03:00