1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

21 commits

Author SHA1 Message Date
Dmytro Vasin
e3fcd96dc4 Fix stoppable events in tests and docs. 2018-04-14 19:44:14 +03:00
Guillermo Iguaran
91f4e335b5
Merge pull request #32404 from mathieumahe/master
Extract the confirm call in its own, overridable method in rails_ujs
2018-04-02 10:50:10 -05:00
Raymond Zhou
e06b672050 Fix typo in rails-ujs HTML content test
`</ps>` is not a valid closing tag for `<p>`.
2018-04-01 16:21:22 -04:00
Mathieu
e9aa7ecdee Extract the confirm call in its own, overridable method in rails_ujs 2018-04-01 19:15:36 +07:00
Raymond Zhou
48e44edfd0 Pass HTML responses as plain-text in rails-ujs
Running HTML responses through `DOMParser#parseFromString` results in
complete `HTMLDocument` instances with unnecessary surrounding tags.

For example:

    new DOMParser().parseFromString('<p>hello</p>', 'text/html')

Will output:

    <html>
      <head></head>
      <body>
        <p>hello</p>
      </body>
    </html>

This is passed to the `ajax:success` handler as `event.detail[0]`
(`data`), but cannot be used directly without first traversing the
document.

To resolve this, only XML content is passed through `parseFromString`,
while HTML content is treated as plain-text.

This matches the behavior of jquery-ujs, which relied on jQuery's
response-type inference.
2018-03-19 03:24:56 -04:00
Andrew White
31abee0341 Add support for automatic nonce generation for Rails UJS
Because the UJS library creates a script tag to process responses it
normally requires the script-src attribute of the content security
policy to include 'unsafe-inline'.

To work around this we generate a per-request nonce value that is
embedded in a meta tag in a similar fashion to how CSRF protection
embeds its token in a meta tag. The UJS library can then read the
nonce value and set it on the dynamically generated script tag to
enable it to execute without needing 'unsafe-inline' enabled.

Nonce generation isn't 100% safe - if your script tag is including
user generated content in someway then it may be possible to exploit
an XSS vulnerability which can take advantage of the nonce. It is
however an improvement on a blanket permission for inline scripts.

It is also possible to use the nonce within your own script tags by
using `nonce: true` to set the nonce value on the tag, e.g

    <%= javascript_tag nonce: true do %>
      alert('Hello, World!');
    <% end %>

Fixes #31689.
2018-02-19 15:59:34 +00:00
ta1kt0me
8b22725c78 Enable to call Rails.ajax without beforeSend 2017-10-28 12:13:19 +09:00
Akira Matsuda
731ea4e3fb Merge pull request #30513 from y-yagi/fix_30444
Does not include disabled element in params
2017-10-25 21:10:37 +09:00
Guillermo Iguaran
b7bf709823 Merge pull request #29127 from DmytroVasin/rails-ujs-remote-callbacks
Fix callback in rails ujs
2017-10-19 09:13:31 -05:00
yuuji.yaginuma
a5d80d4a1c Does not include disabled element in params
In the case of remote, it should be the same behavior as submitting
HTML form.

Fixes #30444
2017-09-03 17:02:38 +09:00
Yoshiyuki Hirano
948c2c48df Use ssl in guide and comment [ci skip] 2017-08-19 08:23:37 +09:00
yuuji.yaginuma
05bbfc5eab Fix test directory to correct path
Together, fix to the following lint violation.

```
rails/actionview/test/ujs/public/test/data-confirm.js
  303:11  error  Strings must use singlequote  quotes

rails/actionview/test/ujs/public/test/data-remote.js
  414:32  error  Extra semicolon  semi

✖ 2 problems (2 errors, 0 warnings)
```
2017-07-30 16:28:10 +09:00
Marc Rendl Ignacio
0093ce16b3 Add jQuery to test vendor files
... so that we can run most, if not all, of rails-ujs
tests without necessarily requiring an internet connection.
2017-07-20 20:49:05 +08:00
Vasin Dmitriy
19afeaf580 Fix callback in rails ujs 2017-06-07 08:33:33 +03:00
Dmytro Vasin
db65f73f2e Fix mistake in JS response parser:
-
  Restore ability to accept ecmascript
  JS response should not modify DOM.
2017-04-13 16:58:36 +03:00
Dmytro Vasin
dc8ddea563 Set current page as default for ajax requests 2017-04-11 06:56:52 +03:00
Patrick Toomey
9ca712348e
Prevent event propogation if element is disabled when event chain begins.
The existing UJS event behavior relies on browsers not sending events for
various events when an element is disabled. For example, imagine the following:

    <button type="submit" disabled="disabled">Click me</button>

The above button is disabled, so browsers will not trigger a click event and
all UJS behavior is prevented. However, imagine a button like this:

    <button type="submit" disabled="disabled"><strong>Click me</strong></button>

The above is treated differently by browsers such as Chrome/Safari. These
browsers do not consider the strong tag to be disabled, and will trigger click
events. UJS has logic to walk up the DOM to find an associated element subject
to UJS behavior. But, this logic does not take into account the disabled
status of the element.

I originally thought we could simply change the selectors used to match
elements to ignore disabled elements. However, UJS disables some elements as
part of the event chain. So, an element might match early in the chain and
then fail to match later. Instead of changing the selectors I added a callback
to the chain that calls `stopEverything` if an element is disabled when the
event chain begins.
2017-03-09 23:06:18 -07:00
Guillermo Iguaran
41c33bd4b2 Import rails-ujs v0.1.0 from rails/rails-ujs 2017-02-20 14:29:55 +09:00
Benjamin Fleischer
c8b5d828e7 Correct spelling
```
go get -u github.com/client9/misspell/cmd/misspell
misspell  -w -error -source=text .
```
2017-02-05 19:00:18 -06:00
Akira Matsuda
650e46afbc s/an/a/
[ci skip]
2017-01-26 00:56:40 +09:00
Guillermo Iguaran
02568801e6 Add UJS tests 2016-11-26 01:23:07 -05:00