Matthew Draper
|
87b3e226d6
|
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
|
2017-07-02 02:15:17 +09:30 |
|
Kir Shatrov
|
cfade1ec7e
|
Enforce frozen string in Rubocop
|
2017-07-01 02:11:03 +03:00 |
|
Akira Matsuda
|
9360b6be63
|
class Foo < Struct.new(:x) creates an extra unneeded anonymous class
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
2017-01-13 15:13:47 +09:00 |
|
Rafael Mendonça França
|
55f9b8129a
|
Add three new rubocop rules
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
2016-08-16 04:30:11 -03:00 |
|
Xavier Noria
|
783763bde9
|
applies new string literal convention in railties/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
2016-08-06 19:16:09 +02:00 |
|
Guo Xiang Tan
|
d9396a07eb
|
Fix incorrect unsubscription.
|
2014-07-11 16:38:26 +08:00 |
|
thedarkone
|
a0907bbdad
|
"Naked" rescue clauses only catch StandardError subclasses.
Similar to #11497.
|
2013-08-06 17:04:02 +02:00 |
|
thedarkone
|
3af8a91c38
|
Add a missing require.
This makes the rack_logger_test.rb runnable by itself (outside of the `rake test` suite).
|
2013-08-06 17:03:55 +02:00 |
|
Rafael Mendonça França
|
d86ccec097
|
Use the right instrumentation name
The pattern is event.component
Closes #11769
Conflicts:
railties/CHANGELOG.md
|
2013-08-05 18:20:22 -03:00 |
|
Aaron Patterson
|
ffa9540fd3
|
fire a notification when the request stops / starts
|
2013-01-09 15:34:58 -08:00 |
|