Rafael Mendonça França
55f9b8129a
Add three new rubocop rules
...
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Xavier Noria
5b6eb1d58b
modernizes hash syntax in actionpack
2016-08-06 19:35:13 +02:00
Xavier Noria
35b3de8021
applies new string literal convention in actionpack/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:54:50 +02:00
Aaron Patterson
e9777ef62e
default pattern to use a joined string
...
The string we create is almost always the same, so rather than joining
all the time, lets join once, then reuse that string everywhere.
2015-08-17 13:51:38 -07:00
Aaron Patterson
947ebe9a6d
remove Strexp
...
This was a useless object. We can just directly construct a
Path::Pattern object without a Strexp object.
2015-08-13 15:42:46 -07:00
Aaron Patterson
4868692687
pass anchor directly to Pattern
...
the caller already has it, there is no reason to pack it in to an object
and just throw that object away.
2015-08-13 15:16:25 -07:00
Konstantin Haase
0d690d75fb
make OR in journey patterns compile to a valid regular expression
2014-11-29 01:26:10 +01:00
Aaron Patterson
da2cf937aa
no more is_a checks on instantiation
2014-05-29 15:45:42 -07:00
Aaron Patterson
bb207ea7b6
Path::Pattern is instantiated internally, so make the contructor require a strexp object
2014-05-29 15:44:54 -07:00
Aaron Patterson
15ffbedf3b
add an alternate constructor to Strexp that takes a string
2014-05-29 15:23:30 -07:00
zires
35f38b71df
Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful exception message.
2013-02-27 08:26:51 +08:00
Rafael Mendonça França
dc8091b88f
Use ActiveSupport::TestCase in the journey tests
2012-12-31 14:40:43 -03:00
Rafael Mendonça França
5294ad82c6
Alias refute methods to assert_not and perfer assert_not on tests
2012-12-31 13:58:52 -03:00
Andrew White
56fee39c39
Integrate Journey into Action Dispatch
...
Move the Journey code underneath the ActionDispatch namespace so
that we don't pollute the global namespace with names that may
be used for models.
Fixes rails/journey#49 .
2012-12-19 22:13:08 +00:00
