1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

10 commits

Author SHA1 Message Date
Prem Sichanugrist
b84ca28a21 Update to use Subscriber#start instead
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.

Close #23717
2016-02-26 13:23:59 -05:00
Vipul A M
c8915ec335 Added log "Rendering ...", when starting to render a template, to log that we have started to render something, at the very beginning.
This helps to easily identify queries from controller vs views

Fixes #23710
2016-02-26 12:08:51 -05:00
Kasper Timm Hansen
b4700de1ce Instrument cached collection renders.
Augments the collection caching with some instrumentation that's logged.

For collections that have been cached like:

```ruby
<%= render partial: 'notifications/notification', collection: @notifications, cached: true %>
```

We'll output a line showing how many cache hits we had when rendering it:

```
  Rendered collection of notifications/_notification.html.erb [0 / 100 cache hits] (3396.5ms)
```
2016-02-20 18:34:41 +01:00
Guo Xiang Tan
ee35b79d4c Prefer to pass block when logging.
The Logger by default includes a guard which checks for the
logging level. By removing the custom logging guards, we can decouple
the logging guard from the logging action to be done.

This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
2014-07-18 15:04:43 +08:00
Rafael Mendonça França
87d0bde03f Drop one more string allocation 2013-11-09 18:28:32 -02:00
Arun Agrawal
daf226abc8 sub! can return nil
Revert "drop one more string allocation"

This reverts commit 4d15661d6c.
2013-11-07 20:08:32 +01:00
Aaron Patterson
4d15661d6c drop one more string allocation 2013-11-06 14:46:14 -08:00
Aaron Patterson
68b7e381f1 drop string allocations in the log subscriber 2013-11-06 14:37:30 -08:00
Łukasz Strzałkowski
7c8817aeef Add missing require 2013-08-25 11:39:12 +02:00
Piotr Sarnacki
0d6e8edc2a Move actionpack/lib/action_view* into actionview/lib 2013-06-20 17:23:15 +02:00
Renamed from actionpack/lib/action_view/log_subscriber.rb (Browse further)