1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

14 commits

Author SHA1 Message Date
Aaron Patterson
9af4258186 set the error callback to a nice default in case nobody set an error callback and an error happens 2014-02-28 11:57:15 -08:00
Kevin Casey
8508346dd0 Correct prestreaming controller response status.
if the controller action has not yet streamed any data, actions should
process as normal, and errors should trigger the appropriate behavior
(500, or in the case of ActionController::BadRequest, a 400 Bad Request)
2014-02-15 13:05:00 -08:00
Santiago Pastorino
f97fdace54 Merge pull request #11443 from wangjohn/sse_reloader_class
SSE class for ActionController::Live
2013-08-19 07:30:27 -07:00
Gaurish Sharma
28348e0681 Add timeout to test_async_stream
Without timeout:
this test executed infinitely on JRuby
Passes on MRI

With Timeout:
this test gracefully fails on JRuby
Passes on MRI, tested on v2.0 & v1.9.3
2013-08-02 20:27:28 +05:30
wangjohn
d2d6aef510 Creating an SSE class to be used with ActionController::Live. 2013-07-30 03:23:01 -04:00
Sean Griffin
c01d080fd6 Exception handling for controllers using ActionController::Live
Any exceptions that occured at the view or controller level for a
controller using ActionController::Live would cause the server to either
hang with an open socket indefinitely, or immediately crash (depending
on whether the server was launched with rails s or directly). Changed
the behavior of exceptions to act the same as streaming templates for
html requests, and allow for an on_error callback if needed.
2013-03-18 10:41:24 -06:00
Bernard Potocki
2651b597f2 Handle conditional get in live requests - this will prevent error when using stale on live streams(issue #9636) 2013-03-14 09:13:10 +01:00
Rafael Mendonça França
5294ad82c6 Alias refute methods to assert_not and perfer assert_not on tests 2012-12-31 13:58:52 -03:00
Aaron Patterson
c391919180 make sure the body finishes rendering before checking response closure 2012-08-03 00:27:39 -04:00
Aaron Patterson
fa3c4ea6d0 close the response when the response body is set so that normal render calls will work 2012-07-29 21:43:07 -07:00
Aaron Patterson
4509494f70 header hash is duped before being sent up the rack stack 2012-07-29 21:43:07 -07:00
Aaron Patterson
619e7c8db8 make sure set_response! sets the correct response object 2012-07-29 21:43:06 -07:00
Aaron Patterson
38cfbb8aa7 Controller actions are processed in a separate thread for live
responses.

Processing controller actions in a separate thread allows us to work
around the rack api - we can allow the user to set status and headers,
then block until the first bytes are written.  As soon as the first
bytes are written, the main thread can return the status, headers, and
(essentially) a queue for the body.
2012-07-29 21:43:05 -07:00
Aaron Patterson
af0a9f9eef added live responses which can be written and read in separate threads 2012-07-29 21:43:05 -07:00