David Heinemeier Hansson
46da4ee7da
Switch to simpler signed_id for blob rather than full GlobalID
...
We don't need to lookup multiple different classes, so no need to use a globalid.
2017-07-23 11:05:20 -05:00
David Heinemeier Hansson
8f20624820
Switch to a single message verifier
...
No need for this proliferation
2017-07-23 11:03:25 -05:00
David Heinemeier Hansson
d50679f4ee
Move models and jobs to the app setup
...
Follow engine conventions more closely
2017-07-22 09:47:24 -05:00
David Heinemeier Hansson
5b7c31c23a
Unused, we can extract from it out-of-repo
2017-07-22 09:40:53 -05:00
David Heinemeier Hansson
d0a9174d55
Move storage_services.yml to config for consistency
2017-07-22 09:39:42 -05:00
David Heinemeier Hansson
470ba69403
Don't need to validate transformations actually
...
Since they're only ever generated in signed form. Users never have direct access to dictate transformations.
2017-07-22 09:38:16 -05:00
Dino Maric
5fcaa197a7
Assume Rails is defined
2017-07-22 10:25:36 -04:00
Koichi ITO
b44b0f2c3b
Fix RuboCop offenses and warnings
2017-07-22 00:14:46 -04:00
David Heinemeier Hansson
fa33ec9e7d
Anemic intro
2017-07-21 16:34:28 -05:00
David Heinemeier Hansson
dd3eced576
Proper require
2017-07-21 16:24:39 -05:00
David Heinemeier Hansson
796f8330ad
Fix and test VariantsController
2017-07-21 16:12:29 -05:00
David Heinemeier Hansson
7f4111185c
Extract variation value object
2017-07-21 15:51:31 -05:00
David Heinemeier Hansson
cbe89319de
Better naming
2017-07-21 12:35:00 -05:00
David Heinemeier Hansson
beb60b9c3a
True is the same as no arguments
2017-07-20 17:35:41 -05:00
David Heinemeier Hansson
a968e3c3c7
Consistent naming
2017-07-20 17:35:23 -05:00
David Heinemeier Hansson
af99968112
Make processing an explicit step
2017-07-20 17:35:15 -05:00
David Heinemeier Hansson
6c2cef21ce
Fix-up variants controller
2017-07-20 17:34:32 -05:00
David Heinemeier Hansson
1c85eecee0
Move controllers to default engine location for auto loading
2017-07-20 17:34:13 -05:00
David Heinemeier Hansson
1a9026b485
Extract routes.rb to engine location for auto configuration
2017-07-20 17:33:31 -05:00
David Heinemeier Hansson
f1523ab39e
Use a unique blob variant key for storage
2017-07-20 14:06:00 -05:00
David Heinemeier Hansson
76395e3c1b
Do real transformations in a safe way
2017-07-20 14:05:40 -05:00
David Heinemeier Hansson
5dbe5eaeb8
Follow AR like naming of factory method
2017-07-20 14:05:18 -05:00
David Heinemeier Hansson
66d94ed78d
Easier access to the variant of a blob
2017-07-20 14:05:03 -05:00
David Heinemeier Hansson
c2a61cc922
Merge branch 'master' into variants
2017-07-20 12:12:58 -05:00
James Baer
32331b19e1
Accept S3 upload options (e.g. server_side_encryption)
2017-07-20 12:29:37 -04:00
Michael Herold
be526d16fe
Add direct upload support to GCS service
2017-07-17 09:17:09 -04:00
George Claghorn
94a450acbe
Splat options
2017-07-16 19:17:47 -04:00
colorfulfool
993283a1ae
Fix a typo in S3Service
2017-07-16 01:06:39 +03:00
George Claghorn
6074771f79
Swap branches
2017-07-15 08:42:10 -04:00
George Claghorn
147b409e00
Merge pull request #48 from seanhandley/hosted_s3
...
Allow custom endpoints for S3.
2017-07-15 08:29:54 -04:00
Sean Handley
4dd44bc5e8
Allow custom endpoints for S3.
2017-07-15 08:39:56 +01:00
George Claghorn
a4e0e16e05
Put conditional back
2017-07-14 22:35:20 -04:00
Stanislav Gospodinov
315bd5c447
Fixing logger to work with Rails 5.2.0.alpha
2017-07-15 05:15:12 +03:00
George Claghorn
c178de536e
Merge pull request #53 from colorfulfool/error-messages
...
Useful error messages for two possible misconfigurations
2017-07-14 17:29:53 -04:00
colorfulfool
ed977c32e0
Fail early if no storage service is specified
2017-07-15 00:25:43 +03:00
colorfulfool
62e5562edb
Don't fail on boot because of missing S3 keys when S3 is not used
2017-07-15 00:25:07 +03:00
dixpac
c49c56b469
Revert back to the original implementaion with varaibles
...
Revert `exist? and url` to the original implementation.
Since the new one doesn't provide any benefits and makes implementation
harder to follow.
2017-07-14 20:46:02 +02:00
Cristian Bica
6dcdc5c9ab
Added rubocop / codeclimate config and fixed current offenses ( #45 )
2017-07-14 00:09:56 +02:00
dixpac
2a738b31c5
Remove few ivars from gcs_service implementation
2017-07-13 20:43:29 +02:00
George Claghorn
c55af14d1b
Merge pull request #42 from quartzmo/gcs-site-url
...
Update GCSService#url
2017-07-12 12:19:21 -04:00
Chris Smith
afb7047e52
Update GCSService#url
...
Update google-cloud-storage dependency to 1.3
Refactor arguments to Google::Cloud::Storage::File#signed_url
2017-07-12 10:01:12 -06:00
David Heinemeier Hansson
17906fd22f
Revert "S3: slim down service implementation ( #40 )" ( #41 )
...
This reverts commit 6d3962461f
.
2017-07-12 08:44:08 +02:00
Jeremy Daer
6d3962461f
S3: slim down service implementation ( #40 )
...
* Use simple core API for duck-type compat with other clients
* initialize: accept an existing client
* initialize: accept arbitrary client args instead of a fixed, required set
* download: use native get_object streaming, no need to implement range requests
* exists?: use head_object (which returns immediately) rather than waiting for existence
2017-07-11 22:09:39 +02:00
David Heinemeier Hansson
1966c188cf
Very incomplete first stab
2017-07-11 18:53:17 +02:00
George Claghorn
f66a69076f
Expose chunked downloads
2017-07-10 16:23:37 -04:00
David Heinemeier Hansson
f2f5c79790
Accept sgids for existing blobs created via direct upload as an attachable
2017-07-09 18:16:06 +02:00
David Heinemeier Hansson
a19d943f1d
Direct uploads for S3
2017-07-09 18:03:13 +02:00
David Heinemeier Hansson
b1cf901d28
Copypasta comments
...
# Conflicts:
# lib/active_storage/engine.rb
# lib/active_storage/service.rb
# lib/active_storage/service/disk_service.rb
# lib/active_storage/service/s3_service.rb
# test/service/s3_service_test.rb
# test/test_helper.rb
2017-07-09 17:22:19 +02:00
David Heinemeier Hansson
4bfe7af68f
Instrument and log the services
2017-07-09 17:04:28 +02:00
David Heinemeier Hansson
57fd9d2247
Merge pull request #27 from dixpac/fix_configuration_keys_symbolization
...
Symbolize all keys inside configuration nested hash
2017-07-09 15:33:58 +02:00