Yasuo Honda
aa3dcabd87
Add Style/RedundantFreeze to remove redudant .freeze
...
Since Rails 6.0 will support Ruby 2.4.1 or higher
`# frozen_string_literal: true` magic comment is enough to make string object frozen.
This magic comment is enabled by `Style/FrozenStringLiteralComment` cop.
* Exclude these files not to auto correct false positive `Regexp#freeze`
- 'actionpack/lib/action_dispatch/journey/router/utils.rb'
- 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'
It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333
Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.
* Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required
- 'actionpack/test/controller/test_case_test.rb'
- 'activemodel/test/cases/type/string_test.rb'
- 'activesupport/lib/active_support/core_ext/string/strip.rb'
- 'activesupport/test/core_ext/string_ext_test.rb'
- 'railties/test/generators/actions_test.rb'
2018-09-29 07:18:44 +00:00
yuuji.yaginuma
1b86d90136
Enable Performance/UnfreezeString cop
...
In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`.
```ruby
# frozen_string_literal: true
require "bundler/inline"
gemfile(true) do
source "https://rubygems.org "
gem "benchmark-ips"
end
Benchmark.ips do |x|
x.report('+@') { +"" }
x.report('dup') { "".dup }
x.compare!
end
```
```
$ ruby -v benchmark.rb
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
Warming up --------------------------------------
+@ 282.289k i/100ms
dup 187.638k i/100ms
Calculating -------------------------------------
+@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s
dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s
Comparison:
+@: 6775299.3 i/s
dup: 3320400.7 i/s - 2.04x slower
```
2018-09-23 08:56:55 +09:00
bogdanvlviv
ee6bbe403c
Add missing require
...
`activesupport/test/logger_test.rb` requires `tmpdir`.
`activesupport/test/multibyte_test_helpers.rb` requires
`filutils`, `open-uri`, and `tmpdir`.
2018-06-07 15:34:30 +03:00
Koichi ITO
ac717d65a3
[Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment
2017-07-11 13:12:32 +09:00
Kir Shatrov
72950568dd
Use frozen-string-literal in ActiveSupport
2017-07-09 15:08:29 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Matthew Draper
3420a14590
Merge pull request #29540 from kirs/rubocop-frozen-string
...
Enforce frozen string in Rubocop
2017-07-02 01:11:50 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Pat Allan
036bdee4d5
Make ActiveSupport frozen string literal friendly.
...
The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder:
https://github.com/tenderlove/builder/pull/6
Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
2017-06-20 18:04:44 +10:00
Fumiaki MATSUSHIMA
bdcfdef214
Update Unicode Version to 9.0.0
...
9.0.0 was released on June 21, 2016
http://blog.unicode.org/2016/06/announcing-unicode-standard-version-90.html
http://www.unicode.org/versions/Unicode9.0.0/
There are some changes about grapheme cluster in Unicode 9.0.0:
http://unicode.org/reports/tr29/#Grapheme_Cluster_Boundary_Rules
------------
I noticed that `unpack_graphemes` returns [Other] when the argument is Other ÷ Prepend
(it must be [Other, Prepend]).
But in [Unicode 8.0.0's Prepend has no characters](http://www.unicode.org/reports/tr29/tr29-27.html#Prepend )
so we don't have to backport following patch:
```diff
should_break =
+ if pos == eoc
+ true
```
2017-01-28 16:57:36 +09:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces
2016-10-29 01:17:49 -02:00
Rafael Mendonça França
55f9b8129a
Add three new rubocop rules
...
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Xavier Noria
a731125f12
applies new string literal convention in activesupport/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:10:53 +02:00
Vít Ondruch
c245ca30f2
Skip the test if test data download fails.
2016-07-04 14:12:49 +02:00
Vít Ondruch
7d7c2d13ba
DRY Downloader.
2016-07-04 13:11:44 +02:00
Akira Matsuda
c971bc0568
✂️ empty line at the top of files
2015-09-21 01:27:33 +09:00
Vipul A M
6eced6a1fe
Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 onwards.
2015-02-03 20:51:40 +05:30
Akira Matsuda
cc9d1c5201
Avoid mutating the constants in a test case
2014-08-16 10:23:50 +09:00
Sergey Nartimov
1e9e88fcd3
remove checks for encodings availability
2011-12-25 14:34:58 +03:00
Kouhei Sutou
a6e95ba554
fix mixed encoding logs can't be logged.
...
[#4807 state:committed]
Signed-off-by: Kouhei Sutou <kou@cozmixng.org>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-07-19 14:55:58 -07:00
Manfred Stienstra
5795c509a7
Set encoding of the multibyte test helpers file to UTF-8 so the strings can be read by Ruby 1.9.
2008-09-21 18:31:15 +02:00
Manfred Stienstra
3c9eedec3c
Move multibyte test helpers to a separate file and make the conformance tests run again.
2008-09-21 17:37:38 +02:00
