John Hawthorn
6841d0cc6d
Deprecate render layout with an absolute path
...
This has similar problems to render file:.
I've never seen this used, and believe it's a relic from when all
templates could be rendered from an absolute path.
2019-03-29 11:39:40 -07:00
Aaron Patterson
28f88e0074
Pass source to template handler and deprecate old style handler
...
This commit passes the mutated source to the template handler as a
parameter and deprecates the old handlers. Old handlers required that
templates contain a reference to mutated source code, but we would like
to make template objects "read only". This change lets the template
remain "read only" while still giving template handlers access to the
source code after mutations.
2019-02-01 16:19:53 -08:00
Aaron Patterson
3301804ff6
make bot happy
2018-09-24 16:01:34 -07:00
Aaron Patterson
4f96e739c2
Remove deprecated catch-all route in the AV tests
...
This commit removes a deprecated catch-all route in the AV tests. It
defines and includes the necessary routes for each test such that we
don't need the catch-all anymore.
This also helps push us toward #33970
2018-09-24 15:39:15 -07:00
Kir Shatrov
424117281e
Use frozen string literal in actionview/
2017-07-24 11:53:43 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
bogdanvlviv
40bdbce191
Define path with __dir__
...
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df
2017-05-23 00:53:51 +03:00
yuuji.yaginuma
75607a67b4
use Gem.win_platform? to check windows Ruby platforms
...
`Gem.win_platform?` check if it is Windows more accurately.
Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
2016-11-30 20:57:50 +09:00
Xavier Noria
56832e791f
let Regexp#match? be globally available
...
Regexp#match? should be considered to be part of the Ruby core library. We are
emulating it for < 2.4, but not having to require the extension is part of the
illusion of the emulation.
2016-10-27 09:13:55 +02:00
Xavier Noria
63fff600ac
modernizes hash syntax in actionview
2016-08-06 19:36:34 +02:00
Xavier Noria
4b6c68dfb8
applies new string literal convention in actionview/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:50:17 +02:00
Xavier Noria
7ebef567ce
systematic revision of =~ usage in AV
...
Where appropriate, prefer the more concise Regexp#match?,
String#include?, String#start_with?, or String#end_with?
2016-07-25 00:31:35 +02:00
Rafael Mendonça França
8193a09a1f
Revert "Merge pull request #19685 from vngrs/actionview_parent_layout_bug"
...
This reverts commit a9d58c77da041c2c879ahttps://github.com/rails/rails/issues/19626#issuecomment-89862258
and https://github.com/rails/rails/pull/15050#issuecomment-45333449
2015-06-02 20:57:54 -03:00
Guo Xiang Tan
ca83436d1b
Remove assigns and assert_template.
2015-05-30 14:13:57 +08:00
Mehmet Emin İNAÇ
c51aa9f6f2
fix for actionview parent layout bug
...
This commit fixes issue #19626
Don't need to check layout conditions if there is no condition
test for parent layout bug fix
2015-04-08 11:39:29 +03:00
Kuldeep Aggarwal
90aef23e38
No need of requiring rbconfig, it is by-default loaded
2015-01-10 20:27:18 +05:30
Yves Senn
8f247871bb
Merge pull request #15590 from zuhao/refactor_actionview_register_template_handler
...
Add unregister_template_handler to prevent leaks.
Conflicts:
actionview/CHANGELOG.md
2014-06-12 14:06:59 +02:00
Zuhao Wan
a1dbb4e7e0
Add unregister_template_handler to prevent leaks.
2014-06-12 18:49:40 +08:00
Akira Matsuda
222f00b422
Unused classes in AV tests
2013-12-24 11:04:49 +09:00
Łukasz Strzałkowski
7620ab08be
Move actionpack's controller tests
2013-08-25 11:40:10 +02:00
