1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

9 commits

Author SHA1 Message Date
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Akira Matsuda
7f998540af Privatize unneededly protected methods in Action View 2016-12-24 22:16:47 +09:00
Xavier Noria
66a7cfa910 applies new string literal convention in actionview/lib
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:48:35 +02:00
yuuji.yaginuma
b441c5d191 do not use div_for in example [ci skip]
`div_for` removed in 01e94ef
2015-12-22 14:36:24 +09:00
amitkumarsuroliya
ee8feecc57 fix typo intance -> instance in ActionView [ci skip]
`intance` should be `instance`
2015-09-13 20:18:10 +05:30
Prathamesh Sonpatki
25991b94c7 Use existing constant for joining instead of '_' 2015-01-18 13:06:42 +05:30
Robin Dupret
20ea1a2adf Tiny documentation fixes [ci skip] 2014-12-30 17:00:40 +01:00
claudiob
943ebcb5f1 Better docs for AV::RecordIdentifier
This commit intends to clarify the scope of ActionView::RecordIdentifier
methods `dom_id` and `dom_class`.

Most of the current documentation comes from da257eb8 (7 years ago) when
the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern.

Since then, steps have been taken to reach such decoupling, especially
8ca17926 which duplicated ActionController::ModelNaming into
ActionView::ModelNaming explaining that:

> These are just a simple helpers for decoupling Active Model, so it does not
> make sense to extract it to Active Support, but the point is to decouple also
> Action View and Action Pack

As of today, ActionView::RecordIdentifier only includes `dom_id` and `dom_class`
so it makes sense to explicitly document those two methods, and leaving the
details of helpers like `div_for` in the corresponding files.

Moreover, I think it's important to mention in the documentation that
ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work.

[ci skip]
2014-12-23 02:01:53 +01:00
Piotr Sarnacki
0d6e8edc2a Move actionpack/lib/action_view* into actionview/lib 2013-06-20 17:23:15 +02:00
Renamed from actionpack/lib/action_view/record_identifier.rb (Browse further)