This reverts commit abf8de8551.
We should take a deeper look to those cases flat_map doesn't do deep
flattening.
irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
=> [1, 3, 1, 2]
irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
=> [[1, 3], [1, 2]]
Selecting which key extensions to include in active_support/rails
made apparent the systematic usage of Object#in? in the code base.
After some discussion in
5ea6b0df9a
we decided to remove it and use plain Ruby, which seems enough
for this particular idiom.
In this commit the refactor has been made case by case. Sometimes
include? is the natural alternative, others a simple || is the
way you actually spell the condition in your head, others a case
statement seems more appropriate. I have chosen the one I liked
the most in each case.
As mentioned in http://redcloth.org/textile/writing-paragraph-text/#dashes
RedCloth converts double hyphens to emdashes. This causes problems in
the guides where options like --database, --full are rendered incorrectly.
This commit fixes it by customizing the emdash method in the
RedCloth::Formatters::HTML module to just return '--'. See their FAQ
http://redcloth.org/faq in the section 'How do I customize RedCloth?'
Carlos Antonio da Silva