kotovalexarian-likes-github
/
rails--rails
mirror of https://github.com/rails/rails.git
1
0
Fork 0
Code Releases Activity
82,024 Commits 72 Branches 493 Tags 355 MiB
Commit Graph

13 Commits

Author SHA1 Message Date
Ryuta Kamizono c81af6ae72 Enable `Layout/EmptyLinesAroundAccessModifier` cop 
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776,
https://github.com/rails/rails/pull/34832#discussion_r244847195).

Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059).

That cop and enforced style will reduce the our code review cost.
 2019-06-13 12:00:45 +09:00
Gannon McGibbon f5050d998d Add MailDeliveryJob for unified mail delivery 
Add `MailDeliveryJob` for delivering both regular and parameterized mail.
Deprecate using `DeliveryJob` and `Parameterized::DeliveryJob`.
 2018-12-04 11:00:34 -05:00
Gannon McGibbon ebf484a640 Add yield to with_delivery_job test helper 
Adds yield to parameterized mail test helper so assertions
passed into with_delivery_job are actually ran.
 2018-11-30 17:38:26 -05:00
Gannon McGibbon 60339da5bc Deliver parameterized mail with DeliveryJob 
Deliver parameterized mail with `ActionMailer::DeliveryJob`
and remove `ActionMailer::Parameterized::DeliveryJob`.
 2018-11-22 18:37:53 -05:00
Luke Pearce c90c6c1344 Parameterized mailers can configure delivery job 
Setting parameterized_delivery_job on a mailer class will cause Parameterized::MessageDelivery to use
the specified job instead of ActionMailer::Parameterized::DeliveryJob:

    class MyMailer < ApplicationMailer
      self.parameterized_delivery_job = MyCustomDeliveryJob
      ...
    end
 2018-10-05 17:02:40 +01:00
Kir Shatrov 82df8c2ca5 Use frozen string literal in actionmailer/ 2017-07-23 18:17:19 +03:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
 2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
yuuji.yaginuma e4cf71bf7a Remove duplicated `delivery_method` definition 
`ActionMailer::Base.delivery_method` is already defined in
https://github.com/rails/rails/blob/master/actionmailer/test/parameterized_test.rb#L13
 2017-04-07 21:58:08 +09:00
Rafael Mendonça França 0435d65000
Avoid should in test names 2017-01-30 13:28:31 -05:00
Rafael Mendonça França 735aa635c5
Implement respond_to_missing? in the Parameterized::Mailer class 2017-01-30 13:28:14 -05:00
yuuji.yaginuma a28f8b5baf restore `delivery_method` after test 
Currently use two variables to restore `delivery_method`, but the order
of restoring the values is incorrect and does not restore is correctly.
 2017-01-29 00:52:44 +09:00
David Heinemeier Hansson 1cec84ad2d Offer the option to use parameterization for shared processing of headers and ivars (#27825) 
Offer the option to use parameterization for shared processing of headers and ivars
 2017-01-28 11:20:46 +01:00