5 commits

Author	SHA1	Message	Date
Kir Shatrov	831be98f9a	Use frozen-string-literal in ActiveRecord	2017-07-19 22:27:07 +03:00
Matthew Draper	87b3e226d6	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" ... This reverts commit 3420a14590, reversing changes made to afb66a5a59.	2017-07-02 02:15:17 +09:30
Kir Shatrov	cfade1ec7e	Enforce frozen string in Rubocop	2017-07-01 02:11:03 +03:00
Xavier Noria	9617db2078	applies new string literal convention in activerecord/test ... The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.	2016-08-06 18:26:53 +02:00
Seb Jacobs	d5bf649a53	Add support for bidirectional destroy dependencies ... Prior to this commit if you defined a bidirectional relationship between two models with destroy dependencies on both sides, a call to `destroy` would result in an infinite callback loop. Take the following relationship. class Content < ActiveRecord::Base has_one :content_position, dependent: :destroy end class ContentPosition < ActiveRecord::Base belongs_to :content, dependent: :destroy end Calling `Content#destroy` or `ContentPosition#destroy` would result in an infinite callback loop. This commit changes the behaviour of `ActiveRecord::Callbacks#destroy` so that it guards against subsequent callbacks. Thanks to @zetter for demonstrating the issue with failing tests[1]. [1] rails#13609	2015-01-16 11:41:43 +00:00