4 commits

Author	SHA1	Message	Date
Jonathan Hefner	614e813161	Disentangle Action Text from ApplicationController ... This commit allows Action Text to be used without having an ApplicationController defined. In doing so, it also fixes Action Text attachments to render the correct URL host in mailers. It also avoids allocating an ActionController::Renderer per request. Fixes #37183. Fixes #35578. Fixes #36963. Closes #38714. Co-authored-by: Jeremy Daer <jeremydaer@gmail.com>	2020-10-30 01:01:42 +00:00
Sean Doyle	614580270d	Locate fill_in_rich_text_area by <label> text ... This commit dovetails with [#38551] in its focus on improving the ability to test calls to `rich_text_area` in accessibility-minded ways. In addition to searching for `<trix-editor>` elements with the appropriate [`aria-label`][aria-label] attribute, also support locating elements that match the corresponding `<label>` element's text. Now that [basecamp/trix#829][] has been merged and released, clicking on `<label>` elements that reference `<trix-editor>` elements will move focus into the `<trix-editor>` element. There are still some accessible [label text][] improvements that could be made, but extending `fill_in_rich_text_area` to account for `<label for="...">` elements is a good start. [#38551]: https://github.com/rails/rails/pull/38551 [aria-label]: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute [basecamp/trix#829]: https://github.com/basecamp/trix/pull/829 [label text]: https://github.com/basecamp/trix/pull/829#issuecomment-699119852	2020-10-02 18:02:14 -04:00
George Claghorn	b2b6341374	Add ActionDispatch::SystemTestCase#fill_in_rich_text_area	2019-05-13 12:44:06 -04:00
George Claghorn	0decd2ddc4	Import Action Text	2019-01-04 22:22:49 -05:00