mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
c81af6ae72
We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
214 lines
7.3 KiB
Ruby
214 lines
7.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
|
|
class HttpTokenAuthenticationTest < ActionController::TestCase
|
|
class DummyController < ActionController::Base
|
|
before_action :authenticate, only: :index
|
|
before_action :authenticate_with_request, only: :display
|
|
before_action :authenticate_long_credentials, only: :show
|
|
|
|
def index
|
|
render plain: "Hello Secret"
|
|
end
|
|
|
|
def display
|
|
render plain: "Definitely Maybe"
|
|
end
|
|
|
|
def show
|
|
render plain: "Only for loooooong credentials"
|
|
end
|
|
|
|
private
|
|
def authenticate
|
|
authenticate_or_request_with_http_token do |token, _|
|
|
token == "lifo"
|
|
end
|
|
end
|
|
|
|
def authenticate_with_request
|
|
if authenticate_with_http_token { |token, options| token == '"quote" pretty' && options[:algorithm] == "test" }
|
|
@logged_in = true
|
|
else
|
|
request_http_token_authentication("SuperSecret", "Authentication Failed\n")
|
|
end
|
|
end
|
|
|
|
def authenticate_long_credentials
|
|
authenticate_or_request_with_http_token do |token, options|
|
|
token == "1234567890123456789012345678901234567890" && options[:algorithm] == "test"
|
|
end
|
|
end
|
|
end
|
|
|
|
AUTH_HEADERS = ["HTTP_AUTHORIZATION", "X-HTTP_AUTHORIZATION", "X_HTTP_AUTHORIZATION", "REDIRECT_X_HTTP_AUTHORIZATION"]
|
|
|
|
tests DummyController
|
|
|
|
AUTH_HEADERS.each do |header|
|
|
test "successful authentication with #{header.downcase}" do
|
|
@request.env[header] = encode_credentials("lifo")
|
|
get :index
|
|
|
|
assert_response :success
|
|
assert_equal "Hello Secret", @response.body, "Authentication failed for request header #{header}"
|
|
end
|
|
test "successful authentication with #{header.downcase} and long credentials" do
|
|
@request.env[header] = encode_credentials("1234567890123456789012345678901234567890", algorithm: "test")
|
|
get :show
|
|
|
|
assert_response :success
|
|
assert_equal "Only for loooooong credentials", @response.body, "Authentication failed for request header #{header} and long credentials"
|
|
end
|
|
end
|
|
|
|
AUTH_HEADERS.each do |header|
|
|
test "unsuccessful authentication with #{header.downcase}" do
|
|
@request.env[header] = encode_credentials("h4x0r")
|
|
get :index
|
|
|
|
assert_response :unauthorized
|
|
assert_equal "HTTP Token: Access denied.\n", @response.body, "Authentication didn't fail for request header #{header}"
|
|
end
|
|
test "unsuccessful authentication with #{header.downcase} and long credentials" do
|
|
@request.env[header] = encode_credentials("h4x0rh4x0rh4x0rh4x0rh4x0rh4x0rh4x0rh4x0r")
|
|
get :show
|
|
|
|
assert_response :unauthorized
|
|
assert_equal "HTTP Token: Access denied.\n", @response.body, "Authentication didn't fail for request header #{header} and long credentials"
|
|
end
|
|
end
|
|
|
|
test "authentication request with badly formatted header" do
|
|
@request.env["HTTP_AUTHORIZATION"] = 'Token token$"lifo"'
|
|
get :index
|
|
|
|
assert_response :unauthorized
|
|
assert_equal "HTTP Token: Access denied.\n", @response.body, "Authentication header was not properly parsed"
|
|
end
|
|
|
|
test "successful authentication request with Bearer instead of Token" do
|
|
@request.env["HTTP_AUTHORIZATION"] = "Bearer lifo"
|
|
get :index
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
test "authentication request with tab in header" do
|
|
@request.env["HTTP_AUTHORIZATION"] = "Token\ttoken=\"lifo\""
|
|
get :index
|
|
|
|
assert_response :success
|
|
assert_equal "Hello Secret", @response.body
|
|
end
|
|
|
|
test "authentication request without credential" do
|
|
get :display
|
|
|
|
assert_response :unauthorized
|
|
assert_equal "Authentication Failed\n", @response.body
|
|
assert_equal 'Token realm="SuperSecret"', @response.headers["WWW-Authenticate"]
|
|
end
|
|
|
|
test "authentication request with invalid credential" do
|
|
@request.env["HTTP_AUTHORIZATION"] = encode_credentials('"quote" pretty')
|
|
get :display
|
|
|
|
assert_response :unauthorized
|
|
assert_equal "Authentication Failed\n", @response.body
|
|
assert_equal 'Token realm="SuperSecret"', @response.headers["WWW-Authenticate"]
|
|
end
|
|
|
|
test "token_and_options returns correct token" do
|
|
token = "rcHu+HzSFw89Ypyhn/896A=="
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token)).first
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns correct token with value after the equal sign" do
|
|
token = "rcHu+=HzSFw89Ypyhn/896A==f34"
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token)).first
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns correct token with slashes" do
|
|
token = 'rcHu+\\\\"/896A'
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token)).first
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns correct token with quotes" do
|
|
token = '\"quote\" pretty'
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token)).first
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns empty string with empty token" do
|
|
token = +""
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token)).first
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns correct token with nounce option" do
|
|
token = "rcHu+HzSFw89Ypyhn/896A="
|
|
nonce_hash = { nonce: "123abc" }
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(sample_request(token, nonce_hash))
|
|
expected_token = token
|
|
expected_nonce = { "nonce" => nonce_hash[:nonce] }
|
|
assert_equal(expected_token, actual.first)
|
|
assert_equal(expected_nonce, actual.last)
|
|
end
|
|
|
|
test "token_and_options returns nil with no value after the equal sign" do
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(malformed_request).first
|
|
assert_nil actual
|
|
end
|
|
|
|
test "raw_params returns a tuple of two key value pair strings" do
|
|
auth = sample_request("rcHu+HzSFw89Ypyhn/896A=").authorization.to_s
|
|
actual = ActionController::HttpAuthentication::Token.raw_params(auth)
|
|
expected = ["token=\"rcHu+HzSFw89Ypyhn/896A=\"", "nonce=\"def\""]
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
test "token_and_options returns right token when token key is not specified in header" do
|
|
token = "rcHu+HzSFw89Ypyhn/896A="
|
|
|
|
actual = ActionController::HttpAuthentication::Token.token_and_options(
|
|
sample_request_without_token_key(token)
|
|
).first
|
|
|
|
expected = token
|
|
assert_equal(expected, actual)
|
|
end
|
|
|
|
private
|
|
def sample_request(token, options = { nonce: "def" })
|
|
authorization = options.inject([%{Token token="#{token}"}]) do |arr, (k, v)|
|
|
arr << "#{k}=\"#{v}\""
|
|
end.join(", ")
|
|
mock_authorization_request(authorization)
|
|
end
|
|
|
|
def malformed_request
|
|
mock_authorization_request(%{Token token=})
|
|
end
|
|
|
|
def sample_request_without_token_key(token)
|
|
mock_authorization_request(%{Token #{token}})
|
|
end
|
|
|
|
def mock_authorization_request(authorization)
|
|
OpenStruct.new(authorization: authorization)
|
|
end
|
|
|
|
def encode_credentials(token, options = {})
|
|
ActionController::HttpAuthentication::Token.encode_credentials(token, options)
|
|
end
|
|
end
|