mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
6c6c3fa166
`BigDecimal.new` has been deprecated in BigDecimal 1.3.3
which will be a default for Ruby 2.5.
Refer 533737338d
```
$ cd rails/activerecord/
$ git grep -l BigDecimal.new | grep \.rb | xargs sed -i -e "s/BigDecimal.new/BigDecimal/g"
```
- Changes made only to Active Record. Will apply the same change to
other module once this commit is merged.
- The following deprecation has not been addressed because it has been
reported at `ActiveRecord::Result.new`. `ActiveRecord::Result.ancestors`
did not show `BigDecimal`.
* Not addressed
```ruby
/path/to/rails/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb:34:
warning: BigDecimal.new is deprecated
```
* database_statements.rb:34
```ruby
ActiveRecord::Result.new(result.fields, result.to_a) if result
```
* ActiveRecord::Result.ancestors
```ruby
[ActiveRecord::Result,
Enumerable,
ActiveSupport::ToJsonWithActiveSupportEncoder,
Object,
Metaclass::ObjectMethods,
Mocha::ObjectMethods,
PP::ObjectMixin,
ActiveSupport::Dependencies::Loadable,
ActiveSupport::Tryable,
JSON::Ext::Generator::GeneratorMethods::Object,
Kernel,
BasicObject]
```
This commit has been tested with these Ruby and BigDecimal versions
- ruby 2.5 and bigdecimal 1.3.3
```
$ ruby -v
ruby 2.5.0dev (2017-12-14 trunk 61217) [x86_64-linux]
$ gem list |grep bigdecimal
bigdecimal (default: 1.3.3, default: 1.3.2)
```
- ruby 2.4 and bigdecimal 1.3.0
```
$ ruby -v
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux-gnu]
$ gem list |grep bigdecimal
bigdecimal (default: 1.3.0)
```
- ruby 2.3 and bigdecimal 1.2.8
```
$ ruby -v
ruby 2.3.5p376 (2017-09-14 revision 59905) [x86_64-linux]
$ gem list |grep -i bigdecimal
bigdecimal (1.2.8)
```
- ruby 2.2 and bigdecimal 1.2.6
```
$ ruby -v
ruby 2.2.8p477 (2017-09-14 revision 59906) [x86_64-linux]
$ gem list |grep bigdecimal
bigdecimal (1.2.6)
```
209 lines
7.4 KiB
Ruby
209 lines
7.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cases/helper"
|
|
require "support/schema_dumping_helper"
|
|
require "models/default"
|
|
require "models/entrant"
|
|
|
|
class DefaultTest < ActiveRecord::TestCase
|
|
def test_nil_defaults_for_not_null_columns
|
|
%w(id name course_id).each do |name|
|
|
column = Entrant.columns_hash[name]
|
|
assert !column.null, "#{name} column should be NOT NULL"
|
|
assert_not column.default, "#{name} column should be DEFAULT 'nil'"
|
|
end
|
|
end
|
|
|
|
if current_adapter?(:PostgreSQLAdapter)
|
|
def test_multiline_default_text
|
|
record = Default.new
|
|
# older postgres versions represent the default with escapes ("\\012" for a newline)
|
|
assert("--- []\n\n" == record.multiline_default || "--- []\\012\\012" == record.multiline_default)
|
|
end
|
|
end
|
|
end
|
|
|
|
class DefaultNumbersTest < ActiveRecord::TestCase
|
|
class DefaultNumber < ActiveRecord::Base; end
|
|
|
|
setup do
|
|
@connection = ActiveRecord::Base.connection
|
|
@connection.create_table :default_numbers do |t|
|
|
t.integer :positive_integer, default: 7
|
|
t.integer :negative_integer, default: -5
|
|
t.decimal :decimal_number, default: "2.78", precision: 5, scale: 2
|
|
end
|
|
end
|
|
|
|
teardown do
|
|
@connection.drop_table :default_numbers, if_exists: true
|
|
end
|
|
|
|
def test_default_positive_integer
|
|
record = DefaultNumber.new
|
|
assert_equal 7, record.positive_integer
|
|
assert_equal "7", record.positive_integer_before_type_cast
|
|
end
|
|
|
|
def test_default_negative_integer
|
|
record = DefaultNumber.new
|
|
assert_equal (-5), record.negative_integer
|
|
assert_equal "-5", record.negative_integer_before_type_cast
|
|
end
|
|
|
|
def test_default_decimal_number
|
|
record = DefaultNumber.new
|
|
assert_equal BigDecimal("2.78"), record.decimal_number
|
|
assert_equal "2.78", record.decimal_number_before_type_cast
|
|
end
|
|
end
|
|
|
|
class DefaultStringsTest < ActiveRecord::TestCase
|
|
class DefaultString < ActiveRecord::Base; end
|
|
|
|
setup do
|
|
@connection = ActiveRecord::Base.connection
|
|
@connection.create_table :default_strings do |t|
|
|
t.string :string_col, default: "Smith"
|
|
t.string :string_col_with_quotes, default: "O'Connor"
|
|
end
|
|
DefaultString.reset_column_information
|
|
end
|
|
|
|
def test_default_strings
|
|
assert_equal "Smith", DefaultString.new.string_col
|
|
end
|
|
|
|
def test_default_strings_containing_single_quotes
|
|
assert_equal "O'Connor", DefaultString.new.string_col_with_quotes
|
|
end
|
|
|
|
teardown do
|
|
@connection.drop_table :default_strings
|
|
end
|
|
end
|
|
|
|
if current_adapter?(:PostgreSQLAdapter)
|
|
class PostgresqlDefaultExpressionTest < ActiveRecord::TestCase
|
|
include SchemaDumpingHelper
|
|
|
|
test "schema dump includes default expression" do
|
|
output = dump_table_schema("defaults")
|
|
if ActiveRecord::Base.connection.postgresql_version >= 100000
|
|
assert_match %r/t\.date\s+"modified_date",\s+default: -> { "CURRENT_DATE" }/, output
|
|
assert_match %r/t\.datetime\s+"modified_time",\s+default: -> { "CURRENT_TIMESTAMP" }/, output
|
|
else
|
|
assert_match %r/t\.date\s+"modified_date",\s+default: -> { "\('now'::text\)::date" }/, output
|
|
assert_match %r/t\.datetime\s+"modified_time",\s+default: -> { "now\(\)" }/, output
|
|
end
|
|
assert_match %r/t\.date\s+"modified_date_function",\s+default: -> { "now\(\)" }/, output
|
|
assert_match %r/t\.datetime\s+"modified_time_function",\s+default: -> { "now\(\)" }/, output
|
|
end
|
|
end
|
|
end
|
|
|
|
if current_adapter?(:Mysql2Adapter)
|
|
class MysqlDefaultExpressionTest < ActiveRecord::TestCase
|
|
include SchemaDumpingHelper
|
|
|
|
if ActiveRecord::Base.connection.version >= "5.6.0"
|
|
test "schema dump datetime includes default expression" do
|
|
output = dump_table_schema("datetime_defaults")
|
|
assert_match %r/t\.datetime\s+"modified_datetime",\s+default: -> { "CURRENT_TIMESTAMP" }/, output
|
|
end
|
|
end
|
|
|
|
test "schema dump timestamp includes default expression" do
|
|
output = dump_table_schema("timestamp_defaults")
|
|
assert_match %r/t\.timestamp\s+"modified_timestamp",\s+default: -> { "CURRENT_TIMESTAMP" }/, output
|
|
end
|
|
|
|
test "schema dump timestamp without default expression" do
|
|
output = dump_table_schema("timestamp_defaults")
|
|
assert_match %r/t\.timestamp\s+"nullable_timestamp"$/, output
|
|
end
|
|
end
|
|
|
|
class DefaultsTestWithoutTransactionalFixtures < ActiveRecord::TestCase
|
|
# ActiveRecord::Base#create! (and #save and other related methods) will
|
|
# open a new transaction. When in transactional tests mode, this will
|
|
# cause Active Record to create a new savepoint. However, since MySQL doesn't
|
|
# support DDL transactions, creating a table will result in any created
|
|
# savepoints to be automatically released. This in turn causes the savepoint
|
|
# release code in AbstractAdapter#transaction to fail.
|
|
#
|
|
# We don't want that to happen, so we disable transactional tests here.
|
|
self.use_transactional_tests = false
|
|
|
|
def using_strict(strict)
|
|
connection = ActiveRecord::Base.remove_connection
|
|
ActiveRecord::Base.establish_connection connection.merge(strict: strict)
|
|
yield
|
|
ensure
|
|
ActiveRecord::Base.remove_connection
|
|
ActiveRecord::Base.establish_connection connection
|
|
end
|
|
|
|
# Strict mode controls how MySQL handles invalid or missing values
|
|
# in data-change statements such as INSERT or UPDATE. A value can be
|
|
# invalid for several reasons. For example, it might have the wrong
|
|
# data type for the column, or it might be out of range. A value is
|
|
# missing when a new row to be inserted does not contain a value for
|
|
# a non-NULL column that has no explicit DEFAULT clause in its definition.
|
|
# (For a NULL column, NULL is inserted if the value is missing.)
|
|
#
|
|
# If strict mode is not in effect, MySQL inserts adjusted values for
|
|
# invalid or missing values and produces warnings. In strict mode,
|
|
# you can produce this behavior by using INSERT IGNORE or UPDATE IGNORE.
|
|
#
|
|
# https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict
|
|
def test_mysql_not_null_defaults_non_strict
|
|
using_strict(false) do
|
|
with_mysql_not_null_table do |klass|
|
|
record = klass.new
|
|
assert_nil record.non_null_integer
|
|
assert_nil record.non_null_string
|
|
assert_nil record.non_null_text
|
|
assert_nil record.non_null_blob
|
|
|
|
record.save!
|
|
record.reload
|
|
|
|
assert_equal 0, record.non_null_integer
|
|
assert_equal "", record.non_null_string
|
|
assert_equal "", record.non_null_text
|
|
assert_equal "", record.non_null_blob
|
|
end
|
|
end
|
|
end
|
|
|
|
def test_mysql_not_null_defaults_strict
|
|
using_strict(true) do
|
|
with_mysql_not_null_table do |klass|
|
|
record = klass.new
|
|
assert_nil record.non_null_integer
|
|
assert_nil record.non_null_string
|
|
assert_nil record.non_null_text
|
|
assert_nil record.non_null_blob
|
|
|
|
assert_raises(ActiveRecord::NotNullViolation) { klass.create }
|
|
end
|
|
end
|
|
end
|
|
|
|
def with_mysql_not_null_table
|
|
klass = Class.new(ActiveRecord::Base)
|
|
klass.table_name = "test_mysql_not_null_defaults"
|
|
klass.connection.create_table klass.table_name do |t|
|
|
t.integer :non_null_integer, null: false
|
|
t.string :non_null_string, null: false
|
|
t.text :non_null_text, null: false
|
|
t.blob :non_null_blob, null: false
|
|
end
|
|
|
|
yield klass
|
|
ensure
|
|
klass.connection.drop_table(klass.table_name) rescue nil
|
|
end
|
|
end
|
|
end
|