1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionview/test/template
Kasper Timm Hansen 67f81cc72d Add form_with to unify form_tag/form_for. (#26976)
* Add form_with to unify form_tag/form_for.

`form_tag` and `form_for` serve very similar use cases. This
PR unifies that usage such that `form_with` can output just
the opening form tag akin to `form_tag` and can just work with
a url, for instance.

`form_with` by default doesn't attach class or id to the form —
removing them on fields is moved out to a default revisiting PR later.

Ported over old tests where applicable to ensure maximum coverage,
but left some commented out because they don't yet apply (e.g.
`fields_for` later being replaced by `fields`).

[ Kasper Timm Hansen & Marek Kirejczyk ]

* Add fields DSL method.

Strips `_for` and requires models passed as a keyword argument.

* Document form_with.

Graft the `form_for` docs: rewrite, revise and expand where
needed.

Also test that a `format` isn't used when an explicit URL
is passed.

* Enable remote by default.

Brand new world! Forms submit via XHRs by default, woah.

* Invert `include_id` to `skip_id`.

`skip_id: true` reads better than `include_id: false` (since the
`include_id` default is true).

* Invert `remote` to `local`.

Since forms are remote by default, the option name makes more sense
as `local: true`.

* Invert `enforce_utf8` to `skip_enforcing_utf8`.

* Refer to the brand spanking new rails-ujs.

Soon to be bundled in Rails proper, so jquery-ujs is out.

* Make `form_with` a bit more composed.

The flow is still not quite what it should be because the legacy
methods and these new ones pull at opposite ends.

Lots of options have been renamed, so now the new pieces don't fit
in so well.

I'll try to work on this in later commits after this PR (it's likely
there's a much better way to structure this whole part of Action View).
2016-11-21 20:48:51 +01:00
..
erb
form_helper Add form_with to unify form_tag/form_for. (#26976) 2016-11-21 20:48:51 +01:00
testing remove redundant curlies from hash arguments 2016-08-06 19:44:11 +02:00
active_model_helper_test.rb applies remaining conventions across the project 2016-08-06 20:20:22 +02:00
asset_tag_helper_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
atom_feed_helper_test.rb normalizes indentation and whitespace across the project 2016-08-06 20:16:27 +02:00
capture_helper_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
compiled_templates_test.rb Change render to support any hash keys in locals 2016-10-02 00:21:17 -07:00
controller_helper_test.rb code gardening: removes redundant selfs 2016-08-08 01:12:38 +02:00
date_helper_i18n_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
date_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
dependency_tracker_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
digestor_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
erb_util_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
form_collections_helper_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
form_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
form_options_helper_i18n_test.rb modernizes hash syntax in actionview 2016-08-06 19:36:34 +02:00
form_options_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
form_tag_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
html_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
javascript_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
log_subscriber_test.rb Remove deprecated support to :text in render 2016-10-10 00:02:52 -03:00
lookup_context_test.rb improve error message when include assertions fail 2016-09-16 12:03:37 -07:00
number_helper_test.rb Add three new rubocop rules 2016-08-16 04:30:11 -03:00
output_safety_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
partial_iteration_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
record_identifier_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
record_tag_helper_test.rb applies remaining conventions across the project 2016-08-06 20:20:22 +02:00
render_test.rb improve error message when include assertions fail 2016-09-16 12:03:37 -07:00
resolver_cache_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
resolver_patterns_test.rb remove redundant curlies from hash arguments 2016-08-06 19:44:11 +02:00
sanitize_helper_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
streaming_render_test.rb modernizes hash syntax in actionview 2016-08-06 19:36:34 +02:00
tag_helper_test.rb fixes remaining RuboCop issues [Vipul A M, Xavier Noria] 2016-09-01 23:41:49 +02:00
template_error_test.rb Deprecate exception#original_exception in favor of exception#cause 2015-11-03 06:54:34 -08:00
template_test.rb fix RuboCop errors re \xFC 2016-09-02 00:04:27 +02:00
test_case_test.rb Remove deprecated support to :text in render 2016-10-10 00:02:52 -03:00
test_test.rb modernizes hash syntax in actionview 2016-08-06 19:36:34 +02:00
text_helper_test.rb Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
text_test.rb applies new string literal convention in actionview/test 2016-08-06 18:50:17 +02:00
translation_helper_test.rb modernizes hash syntax in actionview 2016-08-06 19:36:34 +02:00
url_helper_test.rb Merge pull request #26810 from maclover7/jm-fix-26802 2016-10-22 01:11:58 -03:00