1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionmailer/lib/action_mailer
Jeremy Daer 95e06e6682 Disallow calling #deliver_later after local message modifications.
They would be lost when the delivery job is enqueued, otherwise.
Prevents a common, hard-to-find bug like:

```ruby
message = Notifier.welcome(user, foo)
message.message_id = my_generated_message_id
message.deliver_later
```

The message_id is silently lost here! *Only the mailer arguments are
passed to the delivery job.*

This raises an exception now.

Make modifications to the message within the mailer method or use a
custom Active Job to manage delivery instead of using #deliver_later.
2016-04-07 13:36:50 -07:00
..
base.rb Update base.rb 2016-03-03 23:54:41 -08:00
collector.rb Revert "ActionMailer::Collector should be nodoc'd" 2013-05-19 21:06:38 +05:30
delivery_job.rb Revert "Merge pull request #20758 from xijo/action_mailer_message_delivery_respects_i18n_locale" 2015-07-07 22:11:20 +02:00
delivery_methods.rb Sendmail default arguments match Mail::SendMail 2016-04-05 14:11:37 -05:00
gem_version.rb Prep release for Rails 5 beta3 2016-02-24 10:27:02 -05:00
inline_preview_interceptor.rb Change 'a HTML' to 'an HTML' [ci skip] 2016-03-03 19:33:00 +05:30
log_subscriber.rb Remove newlines from start of logs 2015-10-26 14:58:18 +00:00
mail_helper.rb [ci skip] Add code example for MailHelper#block_format documentation 2015-03-02 15:01:57 +03:00
message_delivery.rb Disallow calling #deliver_later after local message modifications. 2016-04-07 13:36:50 -07:00
preview.rb Revert "Merge pull request #18446 from cloud8421/actionmailer-unregister-interceptor" 2015-11-23 15:01:24 -07:00
railtie.rb Prevent not-intended loading of ActionDispatch::IntegrationTest 2016-03-07 16:48:18 +09:00
test_case.rb fix class name typo. 2016-02-16 11:57:06 +01:00
test_helper.rb Fixed wording in Assertion docs, changed ‘Assert’ -> ‘Asserts’ 2015-10-07 21:07:46 +05:30
version.rb Pass through AM documentation re: 02d048d [ci skip] 2014-05-26 16:45:50 -07:00