1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activemodel/lib/active_model
Edouard CHIN 06756290d5 Fix AM::Errors.added? trying to generate a message:
- When a ActiveRecord record get saved and validated as part of a
  collection association, the errors attribute are changed to reflect
  the children names. You end up with an error attribute that will
  look like this:

  `author.errors # {:'books.title' => [:blank]}`

  2fe20cb55c/activerecord/lib/active_record/autosave_association.rb (L331-L340)

  We then can't check if the `books.title` errors was added using
  `ActiveModel::Errors#added?` because it tries to generate a message
  to make the match and end up calling the "books.title" method
  on the Author.

  ```
  author.errors.added?(:'books.title', :blank) => NoMethodError: undefined method `books.title'
  ```

  This patch modify the behaviour of `strict_match?` to not generate
  a message to make the comparison but instead make a strict
  comparison with the `options` from the error.
2019-07-10 23:33:32 +02:00
..
attribute Active Model: Use private attr_reader 2018-02-26 06:16:24 +09:00
attribute_set Active Model: Use private attr_reader 2018-02-26 06:16:24 +09:00
locale
serializers Improve doc for :root option in as_json() [ci skip] 2019-05-13 15:35:50 +05:30
type Avoid redundant time.getutc call if it is already utc time object 2019-06-18 01:03:21 +09:00
validations Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
attribute.rb update_columns raises if the column is unknown 2018-10-30 12:52:23 -06:00
attribute_assignment.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
attribute_methods.rb Update comment in attribute_method_matchers_matching 2019-04-23 14:24:40 +09:00
attribute_mutation_tracker.rb PERF: 2x ~ 30x faster dirty tracking 2019-04-11 16:30:40 +09:00
attribute_set.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
attributes.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
callbacks.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
conversion.rb Add Style/RedundantFreeze to remove redudant .freeze 2018-09-29 07:18:44 +00:00
dirty.rb Update docs on dirty.rb 2019-07-05 10:24:01 -07:00
error.rb Fix AM::Errors.added? trying to generate a message: 2019-07-10 23:33:32 +02:00
errors.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
forbidden_attributes_protection.rb Use frozen string literal in activemodel/ 2017-07-16 20:11:16 +03:00
gem_version.rb Start Rails 6.1 development 2019-04-24 15:57:14 -04:00
lint.rb Fix spec 2019-03-31 22:59:12 +08:00
model.rb Use frozen string literal in activemodel/ 2017-07-16 20:11:16 +03:00
naming.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
nested_error.rb Nested attribute error's attribute name to use different key: 2019-03-31 22:59:12 +08:00
railtie.rb Rename i18n_full_message config option to i18n_customize_full_message 2019-03-29 21:38:48 +05:30
secure_password.rb Refactor has_secure_password to extract dedicated attribute module 2019-04-05 01:55:00 +09:00
serialization.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
translation.rb Use frozen string literal in activemodel/ 2017-07-16 20:11:16 +03:00
type.rb Fix doc typo [ci skip] 2017-12-12 16:34:19 -05:00
validations.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
validator.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
version.rb Use frozen string literal in activemodel/ 2017-07-16 20:11:16 +03:00