1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/lib/action_dispatch/system_testing
Uwe Kubosch 1dfcffb583
Don't start the server for the failure screenshot
When `before_setup` fails, for example with fixture errors, the failure is stored, `setup` is skipped, and `take_failed_screenshot` is called.  Taking a screenshot triggers starting the server which will probably fail since fixtures are not properly loaded.  This generates another failure and makes it harder to debug the fixture failure.

If the server was not already started, it makes no sense to take a screenshot since it is not relevant.

This commit skips taking a failure screenshot if no browser session has been started.
2021-12-11 11:58:51 +01:00
..
test_helpers Don't start the server for the failure screenshot 2021-12-11 11:58:51 +01:00
browser.rb Rails 7.0 requires selenium-webdriver >= 4.0.0 2021-10-20 22:48:05 +09:00
driver.rb Rails 7.0 requires selenium-webdriver >= 4.0.0 2021-10-20 22:48:05 +09:00
server.rb Change the system tests to set Puma as default server only when the user haven't specified manually another server. 2017-12-09 16:46:31 -05:00