mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
614580270d
This commit dovetails with [#38551] in its focus on improving the ability to test calls to `rich_text_area` in accessibility-minded ways. In addition to searching for `<trix-editor>` elements with the appropriate [`aria-label`][aria-label] attribute, also support locating elements that match the corresponding `<label>` element's text. Now that [basecamp/trix#829][] has been merged and released, clicking on `<label>` elements that reference `<trix-editor>` elements will move focus into the `<trix-editor>` element. There are still some accessible [label text][] improvements that could be made, but extending `fill_in_rich_text_area` to account for `<label for="...">` elements is a good start. [#38551]: https://github.com/rails/rails/pull/38551 [aria-label]: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute [basecamp/trix#829]: https://github.com/basecamp/trix/pull/829 [label text]: https://github.com/basecamp/trix/pull/829#issuecomment-699119852 |
||
|---|---|---|
| .. | ||
| app | ||
| bin | ||
| config | ||
| db | ||
| lib/assets | ||
| log | ||
| public | ||
| storage | ||
| tmp | ||
| .browserslistrc | ||
| .postcssrc.yml | ||
| babel.config.js | ||
| config.ru | ||
| package.json | ||
| postcss.config.js | ||
| Rakefile | ||
| yarn.lock | ||