1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/test
Alex Smith 0680658624 Allow 'private, no-store' Cache-Control header
https://github.com/rails/rails/pull/39461 changed the `no-store`
directive for the `Cache-Control` header to be exclusive, i.e. when
setting `Cache-Control` to `private, no-store`, this is simplified to
just `no-store`. `private` should typically be superfluous there, but
it's not always.

For instance, Fastly "does not currently respect no-store or no-cache
directives" and says that "if you need to prevent caching by both Fastly
and web browsers, we recommend combining the private directive with
max-age=0 or no-store".

https://docs.fastly.com/en/guides/configuring-caching#do-not-cache

Since it's not possible to override this directive reduction behaviour,
the changes in #39461 prevent Fastly users from upgrading Rails.

This changes the behaviour to allow setting a 'private, no-store' header
when private is specified - similar to how 'public' can be specified
when 'no-cache' is, but not as a default.

Fixes https://github.com/rails/rails/issues/40798
2021-04-05 14:20:17 +10:00
..
abstract Fix nil translation key lookup in controllers 2020-12-22 21:17:51 +07:00
assertions
controller Provide context when logging unpermitted parameters 2021-03-31 17:15:23 -06:00
dispatch Allow 'private, no-store' Cache-Control header 2021-04-05 14:20:17 +10:00
fixtures Allow rails to serve brotli encoded assets 2020-06-01 08:57:02 -07:00
journey actionpack: Improve performance by allowing routes with custom regexes in the FSM. 2021-01-06 09:54:44 +11:00
lib Include layout when rendering objects from controllers 2020-10-14 11:49:45 -06:00
routing
support Move Path::Pattern factories into test helper 2020-07-27 12:23:33 -04:00
abstract_unit.rb Stop using a singleton for routes 2020-07-14 13:46:54 -04:00