mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
6e638bba59
People are often trying to use ARel nodes inside ActiveRecord, and when they do so, lots of things can break, because ActiveRecord relies on Array#uniq and sometimes hash key equality to handle values that end up in wheres, havings, etc. By implementing equality for all the nodes, we should hopefully be able to prevent any nodes (even nodes containing other nodes) from failing an equality check they should otherwise pass, and alleviate many of these errors. Fixes #130
67 lines
1.7 KiB
Ruby
67 lines
1.7 KiB
Ruby
require 'helper'
|
|
|
|
describe Arel::Nodes::Over do
|
|
describe 'as' do
|
|
it 'should alias the expression' do
|
|
table = Arel::Table.new :users
|
|
table[:id].count.over.as('foo').to_sql.must_be_like %{
|
|
COUNT("users"."id") OVER () AS foo
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'with literal' do
|
|
it 'should reference the window definition by name' do
|
|
table = Arel::Table.new :users
|
|
table[:id].count.over('foo').to_sql.must_be_like %{
|
|
COUNT("users"."id") OVER "foo"
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'with SQL literal' do
|
|
it 'should reference the window definition by name' do
|
|
table = Arel::Table.new :users
|
|
table[:id].count.over(Arel.sql('foo')).to_sql.must_be_like %{
|
|
COUNT("users"."id") OVER foo
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'with no expression' do
|
|
it 'should use empty definition' do
|
|
table = Arel::Table.new :users
|
|
table[:id].count.over.to_sql.must_be_like %{
|
|
COUNT("users"."id") OVER ()
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'with expression' do
|
|
it 'should use definition in sub-expression' do
|
|
table = Arel::Table.new :users
|
|
window = Arel::Nodes::Window.new.order(table['foo'])
|
|
table[:id].count.over(window).to_sql.must_be_like %{
|
|
COUNT("users"."id") OVER (ORDER BY \"users\".\"foo\")
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'equality' do
|
|
it 'is equal with equal ivars' do
|
|
array = [
|
|
Arel::Nodes::Over.new('foo', 'bar'),
|
|
Arel::Nodes::Over.new('foo', 'bar')
|
|
]
|
|
assert_equal 1, array.uniq.size
|
|
end
|
|
|
|
it 'is not equal with different ivars' do
|
|
array = [
|
|
Arel::Nodes::Over.new('foo', 'bar'),
|
|
Arel::Nodes::Over.new('foo', 'baz')
|
|
]
|
|
assert_equal 2, array.uniq.size
|
|
end
|
|
end
|
|
end
|