1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activerecord/test/models/content.rb
Seb Jacobs d5bf649a53 Add support for bidirectional destroy dependencies
Prior to this commit if you defined a bidirectional relationship
between two models with destroy dependencies on both sides, a call to
`destroy` would result in an infinite callback loop.

Take the following relationship.

    class Content < ActiveRecord::Base
      has_one :content_position, dependent: :destroy
    end

    class ContentPosition < ActiveRecord::Base
      belongs_to :content, dependent: :destroy
    end

Calling `Content#destroy` or `ContentPosition#destroy` would result in
an infinite callback loop.

This commit changes the behaviour of `ActiveRecord::Callbacks#destroy`
so that it guards against subsequent callbacks.

Thanks to @zetter for demonstrating the issue with failing tests[1].

[1] rails#13609
2015-01-16 11:41:43 +00:00

40 lines
814 B
Ruby

class Content < ActiveRecord::Base
self.table_name = 'content'
has_one :content_position, dependent: :destroy
def self.destroyed_ids
@destroyed_ids ||= []
end
before_destroy do |object|
Content.destroyed_ids << object.id
end
end
class ContentWhichRequiresTwoDestroyCalls < ActiveRecord::Base
self.table_name = 'content'
has_one :content_position, foreign_key: 'content_id', dependent: :destroy
after_initialize do
@destroy_count = 0
end
before_destroy do
@destroy_count += 1
if @destroy_count == 1
throw :abort
end
end
end
class ContentPosition < ActiveRecord::Base
belongs_to :content, dependent: :destroy
def self.destroyed_ids
@destroyed_ids ||= []
end
before_destroy do |object|
ContentPosition.destroyed_ids << object.id
end
end