mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
452f9ee0bc
Active Job logging instrumentation is changed to log errors (with backtrace) when a job raises an exception in #perform. This improves debugging during development and test with the default configuration. Prior to Rails 5, the default development configuration ran jobs with InlineAdapter, which would raise exceptions to the caller and be shown in the development log. In Rails 5, the default adapter was changed to AsyncAdapter, which would silently swallow exceptions and log a "Performed SomeJob from Async..." info message. This could be confusing to a developer, as it would seem that the job was performed successfully. This patch removes the "Performed..." info message from the log and adds an error-level "Error performing SomeJob..." log message which includes the exception backtrace for jobs that raise an exception within the #perform method. It provides this behavior for all adapters.
27 lines
685 B
Ruby
27 lines
685 B
Ruby
require_relative "../support/job_buffer"
|
|
|
|
class RescueJob < ActiveJob::Base
|
|
class OtherError < StandardError; end
|
|
|
|
rescue_from(ArgumentError) do
|
|
JobBuffer.add("rescued from ArgumentError")
|
|
arguments[0] = "DIFFERENT!"
|
|
retry_job
|
|
end
|
|
|
|
rescue_from(ActiveJob::DeserializationError) do |e|
|
|
JobBuffer.add("rescued from DeserializationError")
|
|
JobBuffer.add("DeserializationError original exception was #{e.cause.class.name}")
|
|
end
|
|
|
|
def perform(person = "david")
|
|
case person
|
|
when "david"
|
|
raise ArgumentError, "Hair too good"
|
|
when "other"
|
|
raise OtherError, "Bad hair"
|
|
else
|
|
JobBuffer.add("performed beautifully")
|
|
end
|
|
end
|
|
end
|