mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
1b86d90136
In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`. ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "benchmark-ips" end Benchmark.ips do |x| x.report('+@') { +"" } x.report('dup') { "".dup } x.compare! end ``` ``` $ ruby -v benchmark.rb ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] Warming up -------------------------------------- +@ 282.289k i/100ms dup 187.638k i/100ms Calculating ------------------------------------- +@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s Comparison: +@: 6775299.3 i/s dup: 3320400.7 i/s - 2.04x slower ```
72 lines
3 KiB
Ruby
72 lines
3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "abstract_unit"
|
|
|
|
class JavaScriptHelperTest < ActionView::TestCase
|
|
tests ActionView::Helpers::JavaScriptHelper
|
|
|
|
attr_accessor :output_buffer
|
|
attr_reader :request
|
|
|
|
setup do
|
|
@old_escape_html_entities_in_json = ActiveSupport.escape_html_entities_in_json
|
|
ActiveSupport.escape_html_entities_in_json = true
|
|
@template = self
|
|
@request = Class.new do
|
|
def send_early_hints(links) end
|
|
end.new
|
|
end
|
|
|
|
def teardown
|
|
ActiveSupport.escape_html_entities_in_json = @old_escape_html_entities_in_json
|
|
end
|
|
|
|
def test_escape_javascript
|
|
assert_equal "", escape_javascript(nil)
|
|
assert_equal "123", escape_javascript(123)
|
|
assert_equal "en", escape_javascript(:en)
|
|
assert_equal "false", escape_javascript(false)
|
|
assert_equal "true", escape_javascript(true)
|
|
assert_equal %(This \\"thing\\" is really\\n netos\\'), escape_javascript(%(This "thing" is really\n netos'))
|
|
assert_equal %(backslash\\\\test), escape_javascript(%(backslash\\test))
|
|
assert_equal %(dont <\\/close> tags), escape_javascript(%(dont </close> tags))
|
|
assert_equal %(unicode 
 newline), escape_javascript((+%(unicode \342\200\250 newline)).force_encoding(Encoding::UTF_8).encode!)
|
|
assert_equal %(unicode 
 newline), escape_javascript((+%(unicode \342\200\251 newline)).force_encoding(Encoding::UTF_8).encode!)
|
|
|
|
assert_equal %(dont <\\/close> tags), j(%(dont </close> tags))
|
|
end
|
|
|
|
def test_escape_javascript_with_safebuffer
|
|
given = %('quoted' "double-quoted" new-line:\n </closed>)
|
|
expect = %(\\'quoted\\' \\"double-quoted\\" new-line:\\n <\\/closed>)
|
|
assert_equal expect, escape_javascript(given)
|
|
assert_equal expect, escape_javascript(ActiveSupport::SafeBuffer.new(given))
|
|
assert_instance_of String, escape_javascript(given)
|
|
assert_instance_of ActiveSupport::SafeBuffer, escape_javascript(ActiveSupport::SafeBuffer.new(given))
|
|
end
|
|
|
|
def test_javascript_tag
|
|
self.output_buffer = "foo"
|
|
|
|
assert_dom_equal "<script>\n//<![CDATA[\nalert('hello')\n//]]>\n</script>",
|
|
javascript_tag("alert('hello')")
|
|
|
|
assert_equal "foo", output_buffer, "javascript_tag without a block should not concat to output_buffer"
|
|
end
|
|
|
|
# Setting the :extname option will control what extension (if any) is appended to the url for assets
|
|
def test_javascript_include_tag
|
|
assert_dom_equal "<script src='/foo.js'></script>", javascript_include_tag("/foo")
|
|
assert_dom_equal "<script src='/foo'></script>", javascript_include_tag("/foo", extname: false)
|
|
assert_dom_equal "<script src='/foo.bar'></script>", javascript_include_tag("/foo", extname: ".bar")
|
|
end
|
|
|
|
def test_javascript_tag_with_options
|
|
assert_dom_equal "<script id=\"the_js_tag\">\n//<![CDATA[\nalert('hello')\n//]]>\n</script>",
|
|
javascript_tag("alert('hello')", id: "the_js_tag")
|
|
end
|
|
|
|
def test_javascript_cdata_section
|
|
assert_dom_equal "\n//<![CDATA[\nalert('hello')\n//]]>\n", javascript_cdata_section("alert('hello')")
|
|
end
|
|
end
|