mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
cefcc0f66e
Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
22 lines
379 B
Ruby
22 lines
379 B
Ruby
class EchoChannel < ActionCable::Channel::Base
|
|
def subscribed
|
|
stream_from "global"
|
|
end
|
|
|
|
def unsubscribed
|
|
'Goodbye from EchoChannel!'
|
|
end
|
|
|
|
def ding(data)
|
|
transmit(dong: data['message'])
|
|
end
|
|
|
|
def delay(data)
|
|
sleep 1
|
|
transmit(dong: data['message'])
|
|
end
|
|
|
|
def bulk(data)
|
|
ActionCable.server.broadcast "global", wide: data['message']
|
|
end
|
|
end
|