mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
73b1efc58f
1. Conceptually revert #20276 The feature was implemented for the `responders` gem. In the end, they did not need that feature, and have found a better fix (see plataformatec/responders#131). `ImplicitRender` is the place where Rails specifies our default policies for the case where the user did not explicitly tell us what to render, essentially describing a set of heuristics. If the gem (or the user) knows exactly what they want, they could just perform the correct `render` to avoid falling through to here, as `responders` did (the user called `respond_with`). Reverting the patch allows us to avoid exploding the complexity and defining “the fallback for a fallback” policies. 2. `respond_to` and templates are considered exhaustive enumerations If the user specified a list of formats/variants in a `respond_to` block, anything that is not explicitly included should result in an `UnknownFormat` error (which is then caught upstream to mean “406 Not Acceptable” by default). This is already how it works before this commit. Same goes for templates – if the user defined a set of templates (usually in the file system), that set is now considered exhaustive, which means that “missing” templates are considered `UnknownFormat` errors (406). 3. To keep API endpoints simple, the implicit render behavior for actions with no templates defined at all (regardless of formats, locales, variants, etc) are defaulted to “204 No Content”. This is a strictly narrower version of the feature landed in #19036 and #19377. 4. To avoid confusion when interacting in the browser, these actions will raise an `UnknownFormat` error for “interactive” requests instead. (The precise definition of “interactive” requests might change – the spirit here is to give helpful messages and avoid confusions.) Closes #20666, #23062, #23077, #23564 [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]
95 lines
2.8 KiB
Ruby
95 lines
2.8 KiB
Ruby
require 'action_view/base'
|
|
|
|
module ActionView
|
|
module ViewPaths
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
class_attribute :_view_paths
|
|
self._view_paths = ActionView::PathSet.new
|
|
self._view_paths.freeze
|
|
end
|
|
|
|
delegate :template_exists?, :any_templates?, :view_paths, :formats, :formats=,
|
|
:locale, :locale=, :to => :lookup_context
|
|
|
|
module ClassMethods
|
|
def _prefixes # :nodoc:
|
|
@_prefixes ||= begin
|
|
return local_prefixes if superclass.abstract?
|
|
|
|
local_prefixes + superclass._prefixes
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
# Override this method in your controller if you want to change paths prefixes for finding views.
|
|
# Prefixes defined here will still be added to parents' <tt>._prefixes</tt>.
|
|
def local_prefixes
|
|
[controller_path]
|
|
end
|
|
end
|
|
|
|
# The prefixes used in render "foo" shortcuts.
|
|
def _prefixes # :nodoc:
|
|
self.class._prefixes
|
|
end
|
|
|
|
# <tt>LookupContext</tt> is the object responsible for holding all
|
|
# information required for looking up templates, i.e. view paths and
|
|
# details. Check <tt>ActionView::LookupContext</tt> for more information.
|
|
def lookup_context
|
|
@_lookup_context ||=
|
|
ActionView::LookupContext.new(self.class._view_paths, details_for_lookup, _prefixes)
|
|
end
|
|
|
|
def details_for_lookup
|
|
{ }
|
|
end
|
|
|
|
def append_view_path(path)
|
|
lookup_context.view_paths.push(*path)
|
|
end
|
|
|
|
def prepend_view_path(path)
|
|
lookup_context.view_paths.unshift(*path)
|
|
end
|
|
|
|
module ClassMethods
|
|
# Append a path to the list of view paths for this controller.
|
|
#
|
|
# ==== Parameters
|
|
# * <tt>path</tt> - If a String is provided, it gets converted into
|
|
# the default view path. You may also provide a custom view path
|
|
# (see ActionView::PathSet for more information)
|
|
def append_view_path(path)
|
|
self._view_paths = view_paths + Array(path)
|
|
end
|
|
|
|
# Prepend a path to the list of view paths for this controller.
|
|
#
|
|
# ==== Parameters
|
|
# * <tt>path</tt> - If a String is provided, it gets converted into
|
|
# the default view path. You may also provide a custom view path
|
|
# (see ActionView::PathSet for more information)
|
|
def prepend_view_path(path)
|
|
self._view_paths = ActionView::PathSet.new(Array(path) + view_paths)
|
|
end
|
|
|
|
# A list of all of the default view paths for this controller.
|
|
def view_paths
|
|
_view_paths
|
|
end
|
|
|
|
# Set the view paths.
|
|
#
|
|
# ==== Parameters
|
|
# * <tt>paths</tt> - If a PathSet is provided, use that;
|
|
# otherwise, process the parameter into a PathSet.
|
|
def view_paths=(paths)
|
|
self._view_paths = ActionView::PathSet.new(Array(paths))
|
|
end
|
|
end
|
|
end
|
|
end
|