kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/activesupport/test
History
Daniel Colson 4e646bb281
Allow subscribing with a single argument callable 
Fixes #39976

Prior to this commit it was possible to pass a single argument block to
`ActiveSupport::Notifications.subscribe`, rather than 5 separate
arguments:

```rb
ActiveSupport::Notifications.subscribe('some_event') do |event|
  puts "Reacting to #{event.name}"
end
```

But it was not possible to do the same with a lambda, since the lambda
parameter is a required (`:req`) parameter, but we were checking only
for an optional (`:opt`) parameter.

```rb
listener = ->(event) do
  puts "Reacting to #{event.name}"
end

ActiveSupport::Notifications.subscribe('some_event', &listener)
```

It was also not possible to do this with a custom callable object, since
the custom callable does not respond directly to `:parameters` (although
it's `:call` method object does).

```rb
class CustomListener
  def call(event)
    puts "Reacting to #{event.name}"
  end
end

ActiveSupport::Notifications.subscribe('some_event', CustomListener.new)
```

Prior to this commit these examples would have raised `ArgumentError:
wrong number of arguments (given 5, expected 1)`.

With this commit the single argument lambda and custom callable work
like the single argument block.
2020-11-09 22:26:21 -05:00
..
autoloading_fixtures Fix safe_constantize to not raise a LoadError. 2019-01-09 14:52:46 -05:00
cache Merge pull request #40490 from kirs/cache-instrument-store-local 2020-11-05 16:36:50 -05:00
concurrency allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
core_ext Create unit test to use to_time for timestamp in string 2020-11-03 18:51:43 +06:00
dependencies Improve the logic that detects non-autoloaded constants 2018-10-28 16:34:50 +01:00
deprecation allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
file_fixtures
fixtures Concerns learn to be prepended 2020-02-10 02:23:33 +01:00
json ✂️ [ci skip] 2020-09-16 09:52:10 +09:00
messages allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
metadata Remove redundant travel_back 2018-08-31 16:19:58 +09:00
notifications allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
testing allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
xml_mini allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
abstract_unit.rb Parallelize activesupport test suite 2020-01-24 09:54:55 -08:00
actionable_error_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
array_inquirer_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
autoload_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
benchmarkable_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
broadcast_logger_test.rb Remove deprecated LoggerSilence constant 2020-10-30 00:25:50 +00:00
callback_inheritance_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
callbacks_test.rb before_save and after_save in this test class are defined as public methods 2020-10-27 12:13:32 +09:00
class_cache_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
clean_backtrace_test.rb Revert "Merge pull request #39304 from zenspider/zenspider/backtrace_filter_should_never_return_empty" 2020-10-06 22:31:41 +00:00
clean_logger_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
concern_test.rb Fix variable not initialized warnings 2020-03-13 00:14:45 +01:00
configurable_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
configuration_file_test.rb Cast ConfigurationFile#content_path to a string: 2020-02-10 19:12:33 -04:00
constantize_test_cases.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
current_attributes_test.rb Allow access to CurrentAttributes in test teardown 2020-11-09 15:15:42 -05:00
dependencies_test.rb Use LoadError#original_message if available in depend_on 2020-11-02 20:54:29 +00:00
dependencies_test_helpers.rb
deprecation_test.rb Fix deprecate_methods to not expand positional argument hash 2020-01-20 01:48:23 +09:00
descendants_tracker_test_cases.rb Alias direct_descendants as subclasses 2020-06-02 22:57:48 -05:00
descendants_tracker_with_autoloading_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
descendants_tracker_without_autoloading_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
digest_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
encrypted_configuration_test.rb Unique temp paths for encrypted_config_test 2020-01-24 09:54:01 -08:00
encrypted_file_test.rb Improve error when EncryptedFile key length wrong 2020-09-24 19:45:11 -05:00
evented_file_update_checker_test.rb Listen on fork in EventedFileUpdateChecker 2020-09-26 16:35:28 -05:00
executor_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
file_update_checker_shared_tests.rb Lazily evaluate FileUpdateCheckerSharedTests when being included 2019-08-02 06:21:14 +09:00
file_update_checker_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
fork_tracker_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
gzip_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
hash_with_indifferent_access_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
i18n_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
inflector_test.rb Inflections#plurals, singulars, uncountables, humans, acronyms are public attr_readers 2020-10-02 15:53:23 +09:00
inflector_test_cases.rb Revert "Merge pull request #22780 from pauloancheta/master" 2020-02-13 11:41:15 +09:00
key_generator_test.rb Add a separator to the cache key for ActiveSupport::CachingKeyGenerator 2020-05-04 13:56:38 -04:00
lazy_load_hooks_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
log_subscriber_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
logger_test.rb Logger#info, debug, etc. are public methods 2020-10-02 15:52:09 +09:00
message_encryptor_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
message_verifier_test.rb Fix parsing of jsonified expiry date when on AS::Message::Metadata, when ActiveSupport.use_standard_json_time_format = false 2020-06-06 02:12:19 +05:30
multibyte_chars_test.rb Remove deprecated methods in ActiveSupport::Multibyte::Unicode 2020-10-30 00:26:02 +00:00
multibyte_proxy_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
multibyte_test_helpers.rb Remove deprecated methods in ActiveSupport::Multibyte::Unicode 2020-10-30 00:26:02 +00:00
notifications_test.rb Allow subscribing with a single argument callable 2020-11-09 22:26:21 -05:00
number_helper_i18n_test.rb Add :round_mode parameter support to number helpers 2020-01-05 21:23:02 +00:00
number_helper_test.rb Fix rounding of custom-formatted negative amounts 2020-05-20 12:34:20 +02:00
option_merger_test.rb Copy options before delegating in with_options 2020-05-23 22:47:48 +01:00
ordered_hash_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
ordered_options_test.rb Implement #inspect for ActiveSupport::OrderedOptions 2020-08-26 21:50:09 +05:30
parameter_filter_test.rb Fixes TypeError raised for parameter filter if the json data has key as integer 2020-02-28 17:27:58 +09:00
reloader_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
rescuable_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
safe_buffer_test.rb All these tested String methods are public 2020-10-02 15:52:09 +09:00
secure_compare_rotator_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
security_utils_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
share_lock_test.rb ShareLock#exclusive and sharing are both public methods 2020-10-02 15:53:47 +09:00
silence_logger_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
string_inquirer_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
subscriber_test.rb Subscriber.attach_to with inherit_all option 2020-09-22 08:48:46 -04:00
tagged_logging_test.rb Add a regression test for per-fiber tagged logging 2020-07-02 22:37:23 +01:00
test_case_test.rb Merge pull request #37624 2020-02-17 01:32:23 +01:00
time_travel_test.rb Don't encourage using octals for dates and times 2020-01-15 10:57:38 +00:00
time_zone_test.rb Update to TZInfo v2.0.0 2020-03-28 20:42:43 +01:00
time_zone_test_helpers.rb Update to TZInfo v2.0.0 2020-03-28 20:42:43 +01:00
transliterate_test.rb Change all "can not"s to the correct "cannot" 2020-02-04 16:46:55 -05:00
xml_mini_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00
zeitwerk_inflector_test.rb allow running each test with pure ruby path/to/test.rb 2019-12-18 08:49:19 -06:00