mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
fcfca5c700
Freezing the string literal reduces the number of objects allocated during integration test runs. AllocationTracer before: ``` [["/rack/lib/rack/utils.rb", 499, :T_STRING], [50939, 2737, 78553, 0, 13, 1783920]] [["/rails/activesupport/lib/active_support/subscriber.rb", 99, :T_STRING], [44959, 0, 42633, 0, 2, 1670800]] [["/rack/lib/rack/utils.rb", 662, :T_STRING], [32979, 0, 31263, 0, 1, 1226009]] [["/rack/lib/rack/body_proxy.rb", 34, :T_ARRAY], [29988, 0, 28438, 0, 1, 1114320]] [["/rails/activesupport/lib/active_support/callbacks.rb", 165, :T_DATA], [29968, 0, 28422, 0, 2, 3675936]] ``` AllocationTracer after: ``` [["/rack/lib/rack/utils.rb", 499, :T_STRING], [50983, 4080, 67269, 0, 12, 1815600]] [["/rack/lib/rack/utils.rb", 662, :T_STRING], [33001, 0, 28420, 0, 2, 1230809]] [["/rack/lib/rack/body_proxy.rb", 34, :T_ARRAY], [29990, 0, 25812, 0, 1, 1118000]] [["/rails/activesupport/lib/active_support/subscriber.rb", 99, :T_STRING], [29986, 0, 25803, 0, 1, 1117840]] [["/rails/activesupport/lib/active_support/notifications/instrumenter.rb", 52, :T_HASH], [29984, 28, 26133, 0, 11, 4953280]]
125 lines
3.5 KiB
Ruby
125 lines
3.5 KiB
Ruby
require 'active_support/per_thread_registry'
|
|
|
|
module ActiveSupport
|
|
# ActiveSupport::Subscriber is an object set to consume
|
|
# ActiveSupport::Notifications. The subscriber dispatches notifications to
|
|
# a registered object based on its given namespace.
|
|
#
|
|
# An example would be Active Record subscriber responsible for collecting
|
|
# statistics about queries:
|
|
#
|
|
# module ActiveRecord
|
|
# class StatsSubscriber < ActiveSupport::Subscriber
|
|
# def sql(event)
|
|
# Statsd.timing("sql.#{event.payload[:name]}", event.duration)
|
|
# end
|
|
# end
|
|
# end
|
|
#
|
|
# And it's finally registered as:
|
|
#
|
|
# ActiveRecord::StatsSubscriber.attach_to :active_record
|
|
#
|
|
# Since we need to know all instance methods before attaching the log
|
|
# subscriber, the line above should be called after your subscriber definition.
|
|
#
|
|
# After configured, whenever a "sql.active_record" notification is published,
|
|
# it will properly dispatch the event (ActiveSupport::Notifications::Event) to
|
|
# the +sql+ method.
|
|
class Subscriber
|
|
class << self
|
|
|
|
# Attach the subscriber to a namespace.
|
|
def attach_to(namespace, subscriber=new, notifier=ActiveSupport::Notifications)
|
|
@namespace = namespace
|
|
@subscriber = subscriber
|
|
@notifier = notifier
|
|
|
|
subscribers << subscriber
|
|
|
|
# Add event subscribers for all existing methods on the class.
|
|
subscriber.public_methods(false).each do |event|
|
|
add_event_subscriber(event)
|
|
end
|
|
end
|
|
|
|
# Adds event subscribers for all new methods added to the class.
|
|
def method_added(event)
|
|
# Only public methods are added as subscribers, and only if a notifier
|
|
# has been set up. This means that subscribers will only be set up for
|
|
# classes that call #attach_to.
|
|
if public_method_defined?(event) && notifier
|
|
add_event_subscriber(event)
|
|
end
|
|
end
|
|
|
|
def subscribers
|
|
@@subscribers ||= []
|
|
end
|
|
|
|
protected
|
|
|
|
attr_reader :subscriber, :notifier, :namespace
|
|
|
|
def add_event_subscriber(event)
|
|
return if %w{ start finish }.include?(event.to_s)
|
|
|
|
pattern = "#{event}.#{namespace}"
|
|
|
|
# don't add multiple subscribers (eg. if methods are redefined)
|
|
return if subscriber.patterns.include?(pattern)
|
|
|
|
subscriber.patterns << pattern
|
|
notifier.subscribe(pattern, subscriber)
|
|
end
|
|
end
|
|
|
|
attr_reader :patterns # :nodoc:
|
|
|
|
def initialize
|
|
@queue_key = [self.class.name, object_id].join "-"
|
|
@patterns = []
|
|
super
|
|
end
|
|
|
|
def start(name, id, payload)
|
|
e = ActiveSupport::Notifications::Event.new(name, Time.now, nil, id, payload)
|
|
parent = event_stack.last
|
|
parent << e if parent
|
|
|
|
event_stack.push e
|
|
end
|
|
|
|
def finish(name, id, payload)
|
|
finished = Time.now
|
|
event = event_stack.pop
|
|
event.end = finished
|
|
event.payload.merge!(payload)
|
|
|
|
method = name.split('.'.freeze).first
|
|
send(method, event)
|
|
end
|
|
|
|
private
|
|
|
|
def event_stack
|
|
SubscriberQueueRegistry.instance.get_queue(@queue_key)
|
|
end
|
|
end
|
|
|
|
# This is a registry for all the event stacks kept for subscribers.
|
|
#
|
|
# See the documentation of <tt>ActiveSupport::PerThreadRegistry</tt>
|
|
# for further details.
|
|
class SubscriberQueueRegistry # :nodoc:
|
|
extend PerThreadRegistry
|
|
|
|
def initialize
|
|
@registry = {}
|
|
end
|
|
|
|
def get_queue(queue_key)
|
|
@registry[queue_key] ||= []
|
|
end
|
|
end
|
|
end
|