mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
f88f5a457c
Since at leastcf4afc4we have preferred `assert_not` methods over `refute` methods. I have seen plenty of comments in PRs about this, and we have tried to fix it a few times (5294ad8,e45f176,8910f12,41f50be,d4cfd54,48a183e, and211adb4), but the `refute` methods keep sneaking back in. This custom RuboCop will take care of enforcing this preference, so we don't have to think about it again. I suspect there are other similar stylistic preferences that could be solved with some custom RuboCops, so I will definitely keep my eyes open. `assert_not` over `assert !` might be a good candidate, for example. I wasn't totally sure if `ci/custom_cops` was the best place to put this, but nothing else seemed quite right. At one point I had it set up as a gem, but I think custom cops like this would have limited value in another context. I want to see how code climate handles the new cops before autocorrecting the existing violations. If things go as expected, I will push another commit with those corrections.
3 lines
73 B
Ruby
3 lines
73 B
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "custom_cops/refute_not"
|