rails--rails/activerecord/test/fixtures/content_positions.yml at 26dc9bc8ee8639b1ad393f4f3f4fa3e1a397b70e - kotovalexarian-likes-github/rails--rails - Forgejo by Causa Arcana

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Seb Jacobs d5bf649a53 Add support for bidirectional destroy dependencies

Prior to this commit if you defined a bidirectional relationship
between two models with destroy dependencies on both sides, a call to
`destroy` would result in an infinite callback loop.

Take the following relationship.

    class Content < ActiveRecord::Base
      has_one :content_position, dependent: :destroy
    end

    class ContentPosition < ActiveRecord::Base
      belongs_to :content, dependent: :destroy
    end

Calling `Content#destroy` or `ContentPosition#destroy` would result in
an infinite callback loop.

This commit changes the behaviour of `ActiveRecord::Callbacks#destroy`
so that it guards against subsequent callbacks.

Thanks to @zetter for demonstrating the issue with failing tests[1].

[1] rails#13609

2015-01-16 11:41:43 +00:00

3 lines

43 B

YAML

Raw Blame History

	`content_positions:`
	`id: 1`
	`content_id: 1`