kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/activesupport/test
History
Edouard CHIN 48b6bacbc5 e4e1b62 broke to_param handling: 
- There was an issue inside controller tests where order params were not respected, the reason
  was because we were calling `Hash#to_query` which sorts the results lexicographically.
  1e4e1b62 fixed that issue by not using `to_query` but instead a utility function provided by rack.
- However with the fix came another issue where it's now no longer possible to do this

  ```
   post :foo, params: { user: User.first }

   # Prior to the patch the controller will receive { "user" => "1" }
   # Whereas now you get { "user": "#<User: ...>" }
  ```

  The fix in this PR is to modify `Hash#to_query` to sort only when it
  doesn't contain an array structure that looks something like "bar[]"

  Ref https://github.com/rails/rails/pull/33341#issuecomment-404039396
2018-07-12 13:04:27 -04:00
..
autoloading_fixtures [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
cache Refactor #33254. 2018-07-01 12:46:15 +02:00
concurrency Prevent deadlocks with load interlock and DB lock. 2017-11-09 10:46:01 -05:00
core_ext e4e1b62 broke to_param handling: 2018-07-12 13:04:27 -04:00
dependencies [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
deprecation Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
file_fixtures
fixtures [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
json Enable Layout/SpaceBeforeComma rubocop rule, and fixed more 2017-12-12 20:00:50 +09:00
messages Fix RotationConfiguration test and remove nil-kind rotates. 2017-09-24 22:58:17 +02:00
metadata Perform self-serialization once metadata is involved. 2017-08-13 20:40:59 +02:00
notifications Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
testing Remove extra include ActiveSupport::Testing::MethodCallAssertions 2018-06-08 23:59:56 +03:00
xml_mini Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
abstract_unit.rb Handle FrozenError if it is available 2017-12-20 11:52:01 +00:00
array_inquirer_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
autoload_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
benchmarkable_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
broadcast_logger_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
callback_inheritance_test.rb Define callbacks on descendants. 2018-02-06 16:05:39 -05:00
callbacks_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
class_cache_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
clean_backtrace_test.rb Enable Layout/FirstParameterIndentation cop 2017-07-17 14:08:32 +09:00
clean_logger_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
concern_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
configurable_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
constantize_test_cases.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
current_attributes_test.rb Merge remote-tracking branch 'origin/master' into unlock-minitest 2017-08-01 17:34:14 -04:00
dependencies_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
dependencies_test_helpers.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
deprecation_test.rb Raise a better exception when a invalid depreation behavior is set 2018-05-18 13:35:09 -04:00
descendants_tracker_test_cases.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
descendants_tracker_with_autoloading_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
descendants_tracker_without_autoloading_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
digest_test.rb Don't include ellipsis in truncated digest output 2017-12-17 00:49:02 +00:00
encrypted_configuration_test.rb Raise an error only when require_master_key is specified 2017-12-18 08:04:15 +09:00
encrypted_file_test.rb Raise an error only when require_master_key is specified 2017-12-18 08:04:15 +09:00
evented_file_update_checker_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
executor_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
file_update_checker_shared_tests.rb Allow rubocop check more files 2018-04-19 23:25:39 +03:00
file_update_checker_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
gzip_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
hash_with_indifferent_access_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
i18n_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
inflector_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
inflector_test_cases.rb Fixed typo in test for activesupport parameterize 2017-11-01 10:27:29 +00:00
key_generator_test.rb Ruby 2.4: take advantage of String#unpack1 2018-03-01 22:42:51 -08:00
lazy_load_hooks_test.rb Use class_eval or instance_eval when triggering lazy load hooks: 2018-07-03 23:29:43 -04:00
log_subscriber_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
logger_test.rb Add missing require 2018-06-07 15:34:30 +03:00
message_encryptor_test.rb Fix minor CodeClimate issue 2017-09-25 14:00:07 +02:00
message_verifier_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
multibyte_chars_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
multibyte_conformance_test.rb Remove unused require 2018-06-07 15:34:31 +03:00
multibyte_grapheme_break_conformance_test.rb Remove unused require 2018-06-07 15:34:31 +03:00
multibyte_normalization_conformance_test.rb Remove unused require 2018-06-07 15:34:31 +03:00
multibyte_proxy_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
multibyte_test_helpers.rb Add missing require 2018-06-07 15:34:30 +03:00
notifications_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
number_helper_i18n_test.rb Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
number_helper_test.rb Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
option_merger_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
ordered_hash_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
ordered_options_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
reloader_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
rescuable_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
safe_buffer_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
security_utils_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
share_lock_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
string_inquirer_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
subscriber_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
tagged_logging_test.rb Merge pull request #28171 from sorra/fresh-thread-tagged-logging 2018-02-03 22:41:39 +09:00
test_case_test.rb added tests for assert_no_difference with multiple expressions 2018-07-08 15:15:16 +02:00
time_travel_test.rb Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
time_zone_test.rb Allow Time.zone.at to receive a second argument 2018-05-30 13:47:39 +01:00
time_zone_test_helpers.rb Fix exception in AS::Timezone.all when any tzinfo data is missing 2018-04-18 21:45:13 +02:00
transliterate_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
xml_mini_test.rb Suppress warning: BigDecimal.new is deprecated 2017-12-15 01:19:57 +00:00