1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activejob/test
Kasper Timm Hansen d258bfe8ac
Consolidate and give context to after callback deprecation
The existing message only mentioned one type of before/after callback,
but the config was named generally. That mismatch is confusing and users
wouldn't necessarily know what the total effect of the config would be.

So instead of handwriting the deprecation warning in the specific instances,
consolidate it in one place and give the appropriate context. That context
is the above, but also that users shouldn't update their app config,
they should uncomment the line in the new defaults file, which now also
has more context.

I'm not totally convinced that we can't move this to when
`after_enqueue`/`after_perform` is called in the job class. Doesn't
seem worth it to blare this after every job enqueue/perform, when we
the score at boot time.

cc @Edouard-chin
2019-12-15 03:20:07 +01:00
..
adapters Remove support for Qu gem. 2018-03-19 21:27:16 +01:00
cases Consolidate and give context to after callback deprecation 2019-12-15 03:20:07 +01:00
integration Run inline jobs in separate threads 2019-11-01 20:14:40 -04:00
jobs Don't run AJ after_enqueue / after_perform when chain is halted: 2019-12-09 17:17:23 +01:00
models [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
support Tidy up the build output for Active Job adapters 2019-10-23 20:47:50 +10:30
helper.rb Fix deprecation being thrown at boot time: 2019-12-13 03:25:03 +01:00