mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
334549b4a5
If the host in `default_url_options` is accidentally set with a protocol such as ``` host: "http://example.com" ``` then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention. This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host. I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted. This is based off of work in #7415 cc/ @pixeltrix ATP Action Mailer and Action Pack
61 lines
1.7 KiB
Ruby
61 lines
1.7 KiB
Ruby
require 'abstract_unit'
|
|
|
|
module TestUrlGeneration
|
|
class WithMountPoint < ActionDispatch::IntegrationTest
|
|
Routes = ActionDispatch::Routing::RouteSet.new
|
|
include Routes.url_helpers
|
|
|
|
class ::MyRouteGeneratingController < ActionController::Base
|
|
include Routes.url_helpers
|
|
def index
|
|
render :text => foo_path
|
|
end
|
|
end
|
|
|
|
Routes.draw do
|
|
get "/foo", :to => "my_route_generating#index", :as => :foo
|
|
|
|
mount MyRouteGeneratingController.action(:index), at: '/bar'
|
|
end
|
|
|
|
def _routes
|
|
Routes
|
|
end
|
|
|
|
def app
|
|
Routes
|
|
end
|
|
|
|
test "generating URLS normally" do
|
|
assert_equal "/foo", foo_path
|
|
end
|
|
|
|
test "accepting a :script_name option" do
|
|
assert_equal "/bar/foo", foo_path(:script_name => "/bar")
|
|
end
|
|
|
|
test "the request's SCRIPT_NAME takes precedence over the route" do
|
|
get "/foo", {}, 'SCRIPT_NAME' => "/new", 'action_dispatch.routes' => Routes
|
|
assert_equal "/new/foo", response.body
|
|
end
|
|
|
|
test "the request's SCRIPT_NAME wraps the mounted app's" do
|
|
get '/new/bar/foo', {}, 'SCRIPT_NAME' => '/new', 'PATH_INFO' => '/bar/foo', 'action_dispatch.routes' => Routes
|
|
assert_equal "/new/bar/foo", response.body
|
|
end
|
|
|
|
test "handling http protocol with https set" do
|
|
https!
|
|
assert_equal "http://www.example.com/foo", foo_url(:protocol => "http")
|
|
end
|
|
|
|
test "extracting protocol from host when protocol not present" do
|
|
assert_equal "httpz://www.example.com/foo", foo_url(host: "httpz://www.example.com", protocol: nil)
|
|
end
|
|
|
|
test "formatting host when protocol is present" do
|
|
assert_equal "http://www.example.com/foo", foo_url(host: "httpz://www.example.com", protocol: "http://")
|
|
end
|
|
end
|
|
end
|
|
|