mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
2c02bc0a47
In order to fix issue #17621 we added a check to validations that determined if a record should be validated. Based on the existing tests and behavior we wanted we determined the best way to do that was by checking if `!record.peristed? || record.changed? || record.marked_for_destruction?` This change didn't make it into a release until now. When #23790 was opened we realized that `valid?` and `invalid?` were broken and did not work on persisted records because of the `!record.persisted?`. While there is still a bug that #17621 brought up, this change was too drastic and should not be a RC blocker. I will work on fixing this so that we don't break `valid?` but also aren't validating parent records through child records if that parent record is validate false. This change removes the code changes to validate and the corresponding tests. It adds tests for two of the bugs found since Rails 5 beta2 release. Fixes #17621 |
||
|---|---|---|
| .. | ||
| locale | ||
| serializers | ||
| type | ||
| validations | ||
| attribute_assignment.rb | ||
| attribute_methods.rb | ||
| callbacks.rb | ||
| conversion.rb | ||
| dirty.rb | ||
| errors.rb | ||
| forbidden_attributes_protection.rb | ||
| gem_version.rb | ||
| lint.rb | ||
| model.rb | ||
| naming.rb | ||
| railtie.rb | ||
| secure_password.rb | ||
| serialization.rb | ||
| test_case.rb | ||
| translation.rb | ||
| type.rb | ||
| validations.rb | ||
| validator.rb | ||
| version.rb | ||