1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actiontext/lib/action_text
Sean Doyle 614580270d Locate fill_in_rich_text_area by <label> text
This commit dovetails with [#38551] in its focus on improving the
ability to test calls to `rich_text_area` in accessibility-minded ways.

In addition to searching for `<trix-editor>` elements with the
appropriate [`aria-label`][aria-label] attribute, also support locating
elements that match the corresponding `<label>` element's text.

Now that [basecamp/trix#829][] has been merged and released, clicking on
`<label>` elements that reference `<trix-editor>` elements will move
focus into the `<trix-editor>` element.

There are still some accessible [label text][] improvements that could
be made, but extending `fill_in_rich_text_area` to account for `<label
for="...">` elements is a good start.

[#38551]: https://github.com/rails/rails/pull/38551
[aria-label]: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute
[basecamp/trix#829]: https://github.com/basecamp/trix/pull/829
[label text]: https://github.com/basecamp/trix/pull/829#issuecomment-699119852
2020-10-02 18:02:14 -04:00
..
attachables Use match? where we don't need MatchData 2019-07-29 14:23:10 +09:00
attachments It may be better to explicitly require 'object/try' where we call try 2019-08-01 18:51:51 +09:00
attachable.rb Adds default trix partial 2019-03-05 11:29:32 -06:00
attachment.rb It may be better to explicitly require 'object/try' where we call try 2019-08-01 18:51:51 +09:00
attachment_gallery.rb Use match? where we don't need MatchData 2019-07-29 14:23:10 +09:00
attribute.rb Add method to confirm rich text content existence by adding ? after content name 2019-12-13 12:58:42 +09:00
content.rb
engine.rb Fix ActiveStorage::Blob → ActionText::TrixAttachment conversion 2019-12-03 05:57:36 -05:00
fragment.rb
gem_version.rb Start Rails 6.1 development 2019-04-24 15:57:14 -04:00
html_conversion.rb
plain_text_conversion.rb Cleanup unneeded blank string params in ActionText 2019-08-23 20:17:38 +02:00
serialization.rb
system_test_helper.rb Locate fill_in_rich_text_area by <label> text 2020-10-02 18:02:14 -04:00
trix_attachment.rb
version.rb