mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
0b6175ac2d
Many named routes have keys that are required to successfully resolve. If a key is left off like this:
<%= link_to 'user', user_path %>
This will produce an error like this:
No route matches {:action=>"show", :controller=>"users"}
Since we know that the :id is missing, we can add extra debugging information to the error message.
No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id]
This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url.
While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious.
This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message.
Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
|
||
|---|---|---|
| .. | ||
| abstract | ||
| activerecord | ||
| assertions | ||
| controller | ||
| dispatch | ||
| fixtures | ||
| lib/controller | ||
| metal | ||
| routing | ||
| template | ||
| tmp | ||
| abstract_unit.rb | ||
| active_record_unit.rb | ||
| ts_isolated.rb | ||