mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
7cc27d749c
This PR moves the `schema_migration` to `migration_context` so that we can access the `schema_migration` per connection. This does not change behavior of the SchemaMigration if you are using one database. This also does not change behavior of any public APIs. `Migrator` is private as is `MigrationContext` so we can change these as needed. We now need to pass a `schema_migration` to `Migrator` so that we can run migrations on the right connection outside the context of a rake task. The bugs this fixes were discovered while debugging the issues around the SchemaCache on initialization with multiple database. It was clear that `get_all_versions` wouldn't work without these changes outside the context of a rake task (because in the rake task we establish a connection and change AR::Base.connection to the db we're running on). Because the `SchemaCache` relies on the `SchemaMigration` information we need to make sure we store it per-connection rather than on ActiveRecord::Base. [Eileen M. Uchitelle & Aaron Patterson]
39 lines
1 KiB
Ruby
39 lines
1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cases/helper"
|
|
|
|
module ActiveRecord
|
|
class Migration
|
|
class LoggerTest < ActiveRecord::TestCase
|
|
# MySQL can't roll back ddl changes
|
|
self.use_transactional_tests = false
|
|
|
|
Migration = Struct.new(:name, :version) do
|
|
def disable_ddl_transaction; false end
|
|
def migrate(direction)
|
|
# do nothing
|
|
end
|
|
end
|
|
|
|
def setup
|
|
super
|
|
@schema_migration = ActiveRecord::Base.connection.schema_migration
|
|
@schema_migration.create_table
|
|
@schema_migration.delete_all
|
|
end
|
|
|
|
teardown do
|
|
@schema_migration.drop_table
|
|
end
|
|
|
|
def test_migration_should_be_run_without_logger
|
|
previous_logger = ActiveRecord::Base.logger
|
|
ActiveRecord::Base.logger = nil
|
|
migrations = [Migration.new("a", 1), Migration.new("b", 2), Migration.new("c", 3)]
|
|
ActiveRecord::Migrator.new(:up, migrations, @schema_migration).migrate
|
|
ensure
|
|
ActiveRecord::Base.logger = previous_logger
|
|
end
|
|
end
|
|
end
|
|
end
|