mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
945aa87466
This commit addresses CI failure of Active Record isolation tests. https://buildkite.com/rails/rails/builds/79936 Follow up #41392 * Steps to reproduce ```ruby $ cd activerecord $ bin/test test/cases/associations/belongs_to_associations_test.rb test/cases/associations/has_many_associations_test.rb test/cases/associations/has_many_through_disable_joins_associations_test.rb test/cases/associations/has_one_associations_test.rb test/cases/connection_adapters/schema_cache_test.rb test/cases/inheritance_test.rb test/cases/migration_test.rb test/cases/store_test.rb test/cases/strict_loading_test.rb ``` Since the entire output is too long, here is the minimum case fixed by this commit. ```ruby $ cd activerecord $ bin/test test/cases/associations/belongs_to_associations_test.rb:38 Using sqlite3 Run options: --seed 34180 E Error: BelongsToAssociationsTest#test_belongs_to: NameError: Rails couldn't find a valid model for Club association. Please provide the :class_name option on the association declaration. If :class_name is already provided, make sure it's an ActiveRecord::Base subclass. /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/reflection.rb:431:in `rescue in compute_class' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/reflection.rb:422:in `compute_class' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/reflection.rb:372:in `klass' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/reflection.rb:722:in `association_primary_key' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/reflection.rb:727:in `join_primary_key' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_row.rb:150:in `block in resolve_sti_reflections' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_row.rb:138:in `each_value' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_row.rb:138:in `resolve_sti_reflections' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_row.rb:92:in `fill_row_model_attributes' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_row.rb:70:in `initialize' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:36:in `new' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:36:in `block in build_table_rows_from' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:35:in `each' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:35:in `map' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:35:in `build_table_rows_from' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixture_set/table_rows.rb:18:in `initialize' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:692:in `new' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:692:in `table_rows' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:633:in `block (2 levels) in insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:632:in `each' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:632:in `block in insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:629:in `each' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:629:in `insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:615:in `read_and_insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:567:in `create_fixtures' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/test_fixtures.rb:268:in `load_fixtures' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/test_fixtures.rb:122:in `setup_fixtures' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/test_fixtures.rb:10:in `before_setup' bin/test test/cases/associations/belongs_to_associations_test.rb:38 Finished in 0.083668s, 11.9520 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ```
321 lines
11 KiB
Ruby
321 lines
11 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cases/helper"
|
|
require "models/admin"
|
|
require "models/admin/user"
|
|
require "models/account"
|
|
|
|
class StoreTest < ActiveRecord::TestCase
|
|
fixtures :'admin/users'
|
|
|
|
setup do
|
|
@john = Admin::User.create!(
|
|
name: "John Doe", color: "black", remember_login: true,
|
|
height: "tall", is_a_good_guy: true,
|
|
parent_name: "Quinn", partner_name: "Dallas",
|
|
partner_birthday: "1997-11-1"
|
|
)
|
|
end
|
|
|
|
test "reading store attributes through accessors" do
|
|
assert_equal "black", @john.color
|
|
assert_nil @john.homepage
|
|
end
|
|
|
|
test "writing store attributes through accessors" do
|
|
@john.color = "red"
|
|
@john.homepage = "37signals.com"
|
|
|
|
assert_equal "red", @john.color
|
|
assert_equal "37signals.com", @john.homepage
|
|
end
|
|
|
|
test "reading store attributes through accessors with prefix" do
|
|
assert_equal "Quinn", @john.parent_name
|
|
assert_nil @john.parent_birthday
|
|
assert_equal "Dallas", @john.partner_name
|
|
assert_equal "1997-11-1", @john.partner_birthday
|
|
end
|
|
|
|
test "writing store attributes through accessors with prefix" do
|
|
@john.partner_name = "River"
|
|
@john.partner_birthday = "1999-2-11"
|
|
|
|
assert_equal "River", @john.partner_name
|
|
assert_equal "1999-2-11", @john.partner_birthday
|
|
end
|
|
|
|
test "accessing attributes not exposed by accessors" do
|
|
@john.settings[:icecream] = "graeters"
|
|
@john.save
|
|
|
|
assert_equal "graeters", @john.reload.settings[:icecream]
|
|
end
|
|
|
|
test "overriding a read accessor" do
|
|
@john.settings[:phone_number] = "1234567890"
|
|
|
|
assert_equal "(123) 456-7890", @john.phone_number
|
|
end
|
|
|
|
test "overriding a read accessor using super" do
|
|
@john.settings[:color] = nil
|
|
|
|
assert_equal "red", @john.color
|
|
end
|
|
|
|
test "updating the store will mark it as changed" do
|
|
@john.color = "red"
|
|
assert_predicate @john, :settings_changed?
|
|
end
|
|
|
|
test "updating the store populates the changed array correctly" do
|
|
@john.color = "red"
|
|
assert_equal "black", @john.settings_change[0]["color"]
|
|
assert_equal "red", @john.settings_change[1]["color"]
|
|
end
|
|
|
|
test "updating the store won't mark it as changed if an attribute isn't changed" do
|
|
@john.color = @john.color
|
|
assert_not_predicate @john, :settings_changed?
|
|
end
|
|
|
|
test "updating the store will mark accessor as changed" do
|
|
@john.color = "red"
|
|
assert @john.color_changed?
|
|
end
|
|
|
|
test "new record and no accessors changes" do
|
|
user = Admin::User.new
|
|
assert_not user.color_changed?
|
|
assert_nil user.color_was
|
|
assert_nil user.color_change
|
|
|
|
user.color = "red"
|
|
assert user.color_changed?
|
|
assert_nil user.color_was
|
|
assert_equal "red", user.color_change[1]
|
|
end
|
|
|
|
test "updating the store won't mark accessor as changed if the whole store was updated" do
|
|
@john.settings = { color: @john.color, some: "thing" }
|
|
assert @john.settings_changed?
|
|
assert_not @john.color_changed?
|
|
end
|
|
|
|
test "updating the store populates the accessor changed array correctly" do
|
|
@john.color = "red"
|
|
assert_equal "black", @john.color_was
|
|
assert_equal "black", @john.color_change[0]
|
|
assert_equal "red", @john.color_change[1]
|
|
end
|
|
|
|
test "updating the store won't mark accessor as changed if the value isn't changed" do
|
|
@john.color = @john.color
|
|
assert_not @john.color_changed?
|
|
end
|
|
|
|
test "nullifying the store mark accessor as changed" do
|
|
color = @john.color
|
|
@john.settings = nil
|
|
assert @john.color_changed?
|
|
assert_equal color, @john.color_was
|
|
assert_equal [color, nil], @john.color_change
|
|
end
|
|
|
|
test "dirty methods for suffixed accessors" do
|
|
@john.configs[:two_factor_auth] = true
|
|
assert @john.two_factor_auth_configs_changed?
|
|
assert_nil @john.two_factor_auth_configs_was
|
|
assert_equal [nil, true], @john.two_factor_auth_configs_change
|
|
end
|
|
|
|
test "dirty methods for prefixed accessors" do
|
|
@john.spouse[:name] = "Lena"
|
|
assert @john.partner_name_changed?
|
|
assert_equal "Dallas", @john.partner_name_was
|
|
assert_equal ["Dallas", "Lena"], @john.partner_name_change
|
|
end
|
|
|
|
test "saved changes tracking for accessors" do
|
|
@john.spouse[:name] = "Lena"
|
|
assert @john.partner_name_changed?
|
|
|
|
@john.save!
|
|
assert_not @john.partner_name_change
|
|
assert @john.saved_change_to_partner_name?
|
|
assert_equal ["Dallas", "Lena"], @john.saved_change_to_partner_name
|
|
assert_equal "Dallas", @john.partner_name_before_last_save
|
|
end
|
|
|
|
test "object initialization with not nullable column" do
|
|
assert_equal true, @john.remember_login
|
|
end
|
|
|
|
test "writing with not nullable column" do
|
|
@john.remember_login = false
|
|
assert_equal false, @john.remember_login
|
|
end
|
|
|
|
test "overriding a write accessor" do
|
|
@john.phone_number = "(123) 456-7890"
|
|
|
|
assert_equal "1234567890", @john.settings[:phone_number]
|
|
end
|
|
|
|
test "overriding a write accessor using super" do
|
|
@john.color = "yellow"
|
|
|
|
assert_equal "blue", @john.color
|
|
end
|
|
|
|
test "preserve store attributes data in HashWithIndifferentAccess format without any conversion" do
|
|
@john.json_data = ActiveSupport::HashWithIndifferentAccess.new(:height => "tall", "weight" => "heavy")
|
|
@john.height = "low"
|
|
assert_equal true, @john.json_data.instance_of?(ActiveSupport::HashWithIndifferentAccess)
|
|
assert_equal "low", @john.json_data[:height]
|
|
assert_equal "low", @john.json_data["height"]
|
|
assert_equal "heavy", @john.json_data[:weight]
|
|
assert_equal "heavy", @john.json_data["weight"]
|
|
end
|
|
|
|
test "convert store attributes from Hash to HashWithIndifferentAccess saving the data and access attributes indifferently" do
|
|
user = Admin::User.find_by_name("Jamis")
|
|
assert_equal "symbol", user.settings[:symbol]
|
|
assert_equal "symbol", user.settings["symbol"]
|
|
assert_equal "string", user.settings[:string]
|
|
assert_equal "string", user.settings["string"]
|
|
assert_equal true, user.settings.instance_of?(ActiveSupport::HashWithIndifferentAccess)
|
|
|
|
user.height = "low"
|
|
assert_equal "symbol", user.settings[:symbol]
|
|
assert_equal "symbol", user.settings["symbol"]
|
|
assert_equal "string", user.settings[:string]
|
|
assert_equal "string", user.settings["string"]
|
|
assert_equal true, user.settings.instance_of?(ActiveSupport::HashWithIndifferentAccess)
|
|
end
|
|
|
|
test "convert store attributes from any format other than Hash or HashWithIndifferentAccess losing the data" do
|
|
@john.json_data = "somedata"
|
|
@john.height = "low"
|
|
assert_equal true, @john.json_data.instance_of?(ActiveSupport::HashWithIndifferentAccess)
|
|
assert_equal "low", @john.json_data[:height]
|
|
assert_equal "low", @john.json_data["height"]
|
|
assert_equal false, @john.json_data.delete_if { |k, v| k == "height" }.any?
|
|
end
|
|
|
|
test "reading store attributes through accessors encoded with JSON" do
|
|
assert_equal "tall", @john.height
|
|
assert_nil @john.weight
|
|
end
|
|
|
|
test "writing store attributes through accessors encoded with JSON" do
|
|
@john.height = "short"
|
|
@john.weight = "heavy"
|
|
|
|
assert_equal "short", @john.height
|
|
assert_equal "heavy", @john.weight
|
|
end
|
|
|
|
test "accessing attributes not exposed by accessors encoded with JSON" do
|
|
@john.json_data["somestuff"] = "somecoolstuff"
|
|
@john.save
|
|
|
|
assert_equal "somecoolstuff", @john.reload.json_data["somestuff"]
|
|
end
|
|
|
|
test "updating the store will mark it as changed encoded with JSON" do
|
|
@john.height = "short"
|
|
assert_predicate @john, :json_data_changed?
|
|
end
|
|
|
|
test "object initialization with not nullable column encoded with JSON" do
|
|
assert_equal true, @john.is_a_good_guy
|
|
end
|
|
|
|
test "writing with not nullable column encoded with JSON" do
|
|
@john.is_a_good_guy = false
|
|
assert_equal false, @john.is_a_good_guy
|
|
end
|
|
|
|
test "all stored attributes are returned" do
|
|
assert_equal [:color, :homepage, :favorite_food], Admin::User.stored_attributes[:settings]
|
|
end
|
|
|
|
test "stored_attributes are tracked per class" do
|
|
first_model = Class.new(ActiveRecord::Base) do
|
|
store_accessor :data, :color
|
|
end
|
|
second_model = Class.new(ActiveRecord::Base) do
|
|
store_accessor :data, :width, :height
|
|
end
|
|
|
|
assert_equal [:color], first_model.stored_attributes[:data]
|
|
assert_equal [:width, :height], second_model.stored_attributes[:data]
|
|
end
|
|
|
|
test "stored_attributes are tracked per subclass" do
|
|
first_model = Class.new(ActiveRecord::Base) do
|
|
store_accessor :data, :color
|
|
end
|
|
second_model = Class.new(first_model) do
|
|
store_accessor :data, :width, :height
|
|
end
|
|
third_model = Class.new(first_model) do
|
|
store_accessor :data, :area, :volume
|
|
end
|
|
|
|
assert_equal [:color], first_model.stored_attributes[:data]
|
|
assert_equal [:color, :width, :height], second_model.stored_attributes[:data]
|
|
assert_equal [:color, :area, :volume], third_model.stored_attributes[:data]
|
|
assert_equal [:color], first_model.stored_attributes[:data]
|
|
end
|
|
|
|
test "YAML coder initializes the store when a Nil value is given" do
|
|
assert_equal({}, @john.params)
|
|
end
|
|
|
|
test "dump, load and dump again a model" do
|
|
dumped = YAML.dump(@john)
|
|
loaded = YAML.respond_to?(:unsafe_load) ? YAML.unsafe_load(dumped) : YAML.load(dumped)
|
|
assert_equal @john, loaded
|
|
|
|
second_dump = YAML.dump(loaded)
|
|
second_loaded = YAML.respond_to?(:unsafe_load) ? YAML.unsafe_load(second_dump) : YAML.load(second_dump)
|
|
assert_equal @john, second_loaded
|
|
end
|
|
|
|
test "read store attributes through accessors with default suffix" do
|
|
@john.configs[:two_factor_auth] = true
|
|
assert_equal true, @john.two_factor_auth_configs
|
|
end
|
|
|
|
test "write store attributes through accessors with default suffix" do
|
|
@john.two_factor_auth_configs = false
|
|
assert_equal false, @john.configs[:two_factor_auth]
|
|
end
|
|
|
|
test "read store attributes through accessors with custom suffix" do
|
|
@john.configs[:login_retry] = 3
|
|
assert_equal 3, @john.login_retry_config
|
|
end
|
|
|
|
test "write store attributes through accessors with custom suffix" do
|
|
@john.login_retry_config = 5
|
|
assert_equal 5, @john.configs[:login_retry]
|
|
end
|
|
|
|
test "read accessor without pre/suffix in the same store as other pre/suffixed accessors still works" do
|
|
@john.configs[:secret_question] = "What is your high school?"
|
|
assert_equal "What is your high school?", @john.secret_question
|
|
end
|
|
|
|
test "write accessor without pre/suffix in the same store as other pre/suffixed accessors still works" do
|
|
@john.secret_question = "What was the Rails version when you first worked on it?"
|
|
assert_equal "What was the Rails version when you first worked on it?", @john.configs[:secret_question]
|
|
end
|
|
|
|
test "prefix/suffix do not affect stored attributes" do
|
|
assert_equal [:secret_question, :two_factor_auth, :login_retry], Admin::User.stored_attributes[:configs]
|
|
end
|
|
end
|