mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
0409ed57ac
As of Ruby 2.7 DidYouMean is included as a default gem, so there is no need to check if DidYouMean is defined in the test suite. We still need to check if the DidYouMean modules are defined in the actual code, as someone might run Rails with DidYouMean disabled by using the `--disable-did_you_mean` flag. This is ussually done for performance reasons. This commit also includes some of the changes made by Yuki in: https://github.com/rails/rails/pull/39555 These changes include replacing Jaro with the more accurate SpellChecker, and using DidYouMean::Correctable for simplere corrections. The DidYouMean::SpellChecker does have a treshold for corrections. If there is not enough similarity it might not return a suggestion. To stop the tests from failing some test data had to be changed. For example, `non_existent` does not meet the treshold for `hello`, but `ello` does: DidYouMean::SpellChecker.new(dictionary: %w[hello]).correct('non_existent') => [] DidYouMean::SpellChecker.new(dictionary: %w[hello]).correct('ello') => ["hello"] The treshold makes sense for spelling errors. But maybe we should add a different SpellChecker that helps to get a suggestion even if there is little overlap. For example for when a model only has 2 attributes (title and body), it's helpful to get a suggestion for `name` Co-Authored-By: Yuki Nishijima <yk.nishijima@gmail.com>
39 lines
1.4 KiB
Ruby
39 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Human < ActiveRecord::Base
|
|
self.table_name = "humans"
|
|
|
|
has_one :face, inverse_of: :human
|
|
has_one :autosave_face, class_name: "Face", autosave: true, foreign_key: :human_id, inverse_of: :autosave_human
|
|
has_one :polymorphic_face, class_name: "Face", as: :polymorphic_human, inverse_of: :polymorphic_human
|
|
has_one :polymorphic_face_without_inverse, class_name: "Face", as: :poly_human_without_inverse
|
|
has_many :interests, inverse_of: :human
|
|
has_many :interests_with_callbacks,
|
|
class_name: "Interest",
|
|
before_add: :add_called,
|
|
after_add: :add_called,
|
|
inverse_of: :human_with_callbacks
|
|
has_many :polymorphic_interests,
|
|
class_name: "Interest",
|
|
as: :polymorphic_human,
|
|
inverse_of: :polymorphic_human
|
|
has_many :polymorphic_interests_with_callbacks,
|
|
class_name: "Interest",
|
|
as: :polymorphic_human,
|
|
before_add: :add_called,
|
|
after_add: :add_called,
|
|
inverse_of: :polymorphic_human
|
|
# These are "broken" inverse_of associations for the purposes of testing
|
|
has_one :confused_face, class_name: "Face", inverse_of: :cnffused_human
|
|
has_many :secret_interests, class_name: "Interest", inverse_of: :secret_human
|
|
has_one :mixed_case_monkey
|
|
|
|
attribute :add_callback_called, :boolean, default: false
|
|
|
|
def add_called(_interest)
|
|
self.add_callback_called = true
|
|
end
|
|
end
|
|
|
|
class SuperHuman < Human
|
|
end
|