mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
470d0e459f
I found a bug that validation callbacks don't fire on multiple context.
So I've fixed it.
Example:
```ruby
class Dog
include ActiveModel::Validations
include ActiveModel::Validations::Callbacks
attr_accessor :history
def initialize
@history = []
end
before_validation :set_before_validation_on_a, on: :a
before_validation :set_before_validation_on_b, on: :b
after_validation :set_after_validation_on_a, on: :a
after_validation :set_after_validation_on_b, on: :b
def set_before_validation_on_a; history << "before_validation on a"; end
def set_before_validation_on_b; history << "before_validation on b"; end
def set_after_validation_on_a; history << "after_validation on a" ; end
def set_after_validation_on_b; history << "after_validation on b" ; end
end
```
Before:
```
d = Dog.new
d.valid?([:a, :b])
d.history # []
```
After:
```
d = Dog.new
d.valid?([:a, :b])
d.history # ["before_validation on a", "before_validation on b", "after_validation on a", "after_validation on b"]
```
|
||
|---|---|---|
| .. | ||
| serializers | ||
| type | ||
| validations | ||
| attribute_assignment_test.rb | ||
| attribute_methods_test.rb | ||
| attribute_set_test.rb | ||
| attribute_test.rb | ||
| attributes_dirty_test.rb | ||
| attributes_test.rb | ||
| callbacks_test.rb | ||
| conversion_test.rb | ||
| dirty_test.rb | ||
| errors_test.rb | ||
| forbidden_attributes_protection_test.rb | ||
| helper.rb | ||
| lint_test.rb | ||
| model_test.rb | ||
| naming_test.rb | ||
| railtie_test.rb | ||
| secure_password_test.rb | ||
| serialization_test.rb | ||
| translation_test.rb | ||
| validations_test.rb | ||