kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/railties/test
History
Yasuo Honda 437fd8f3c7 Lock rails/webpacker npm package version to 5 
This pull request locks `rails/webpacker` npm package version to 5.

railties CI failures are reported at https://buildkite.com/rails/rails/builds/73586 .

It looks like Rails unit test does not support `rails/webpacker` 6 yet.
because `rails/webpacker` 6.0.0-pre.1 has been released recently, which
triggers these errors.

https://www.npmjs.com/package/@rails/webpacker/v/6.0.0-pre.1

This pull request addresses these errors.

```ruby
$ cd railties
$ bin/test test/application/asset_debugging_test.rb -n test_assets_are_concatenated_when_debug_is_off_and_compile_is_off_either_if_debug_assets_param_is_provided
Run options: -n test_assets_are_concatenated_when_debug_is_off_and_compile_is_off_either_if_debug_assets_param_is_provided --seed 62457

E

Error:
ApplicationTests::AssetDebuggingTest#test_assets_are_concatenated_when_debug_is_off_and_compile_is_off_either_if_debug_assets_param_is_provided:
RuntimeError: rails command failed (1): bin/rails assets:precompile --trace 2>&1
... snip ...
Compilation failed:
[webpack-cli] TypeError: Cannot read property 'toWebpackConfig' of undefined
    at Object.<anonymous> (/home/yahonda/src/github.com/rails/rails/tmp/d20201222-730245-pstvl8/app/config/webpack/production.js:3:30)
    at Module._compile (/home/yahonda/src/github.com/rails/rails/railties/test/isolation/assets/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (/home/yahonda/src/github.com/rails/rails/railties/test/isolation/assets/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at requireConfig (/home/yahonda/src/github.com/rails/rails/railties/test/isolation/assets/node_modules/webpack-cli/lib/groups/resolveConfig.js:73:18)
    at /home/yahonda/src/github.com/rails/rails/railties/test/isolation/assets/node_modules/webpack-cli/lib/groups/resolveConfig.js:99:36
    at Array.map (<anonymous>)

    /home/yahonda/src/github.com/rails/rails/railties/test/isolation/abstract_unit.rb:373:in `rails'
    /home/yahonda/src/github.com/rails/rails/railties/test/application/asset_debugging_test.rb:44:in `block in <class:AssetDebuggingTest>'

bin/test test/application/asset_debugging_test.rb:41

Finished in 3.836355s, 0.2607 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$
```
2020-12-22 21:33:00 +09:00
..
application Add config.action_view.preload_links_header option 2020-12-19 05:24:09 +00:00
command Isolate ARGV in Rails::Command.invoke 2020-02-18 15:02:56 -06:00
commands Add support for sqlcmd instead of sqsh on sql server 2020-11-13 00:01:19 +06:00
configuration Get rid of unnecessary meta programming 2020-10-07 11:12:02 +09:00
engine Use the single line editor in console test 2019-12-24 20:47:21 +09:00
fixtures Test Action Text install generator 2020-11-23 18:07:54 -06:00
generators feat(rubocop): Add Style/RedundantRegexpEscape 2020-12-08 18:57:09 +00:00
isolation Lock rails/webpacker npm package version to 5 2020-12-22 21:33:00 +09:00
minitest Fix backtraces for generated plugin tests 2020-10-07 15:40:56 -05:00
railties Wrap evaluation of db/seeds.rb with the executor 2020-11-18 16:26:20 -06:00
test_unit Fixed up error output tests and added a missing failure output test. 2020-05-20 15:54:28 -07:00
abstract_unit.rb Revert "You give jruby_skip & rubinius_skip a good name" 2019-08-02 00:24:11 -04:00
app_loader_test.rb
backtrace_cleaner_test.rb Don't modify relative ./ paths in BacktraceCleaner 2019-10-03 14:06:58 -07:00
chdir_helpers.rb Avoid chdir error in Railties tests on Ruby master 2020-10-04 00:26:03 +01:00
code_statistics_calculator_test.rb Add support for stylesheets and ERB views to rails stats. 2020-11-10 09:40:18 -07:00
code_statistics_test.rb
console_helpers.rb
engine_test.rb
env_helpers.rb
generators_test.rb remove reference to global rails command and replace with bin/rails 2019-12-27 19:32:37 +00:00
initializable_test.rb
json_params_parsing_test.rb
path_generation_test.rb
paths_test.rb
rack_logger_test.rb
rails_info_controller_test.rb
rails_info_test.rb
secrets_test.rb
version_test.rb