mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
ee525ff663
`Dir.glob` doesn't guarantee the order of its results: https://ruby-doc.org/core-2.6.5/Dir.html#method-c-glob > Case sensitivity depends on your system (File::FNM_CASEFOLD is > ignored), as does the order in which the results are returned. Minitest stores a list of all test cases in the order that they were defined; it shuffles them before they're run, but doesn't sort them: https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L1048 https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L156 This means that the order in which framework tests run is platform dependent, and running a test command that failed in CI locally won't necessarily reproduce the error, even when the same seed is provided. `Rake::FileList` resolves glob patterns to a sorted list of files: https://github.com/ruby/rake/blob/v13.0.1/lib/rake/file_list.rb#L408 By using `Rake::FileList` instead of `Dir.glob`, framework tests will always run in the same order when given the same seed, and reproducing order dependent CI failures will be easier.
40 lines
790 B
Ruby
40 lines
790 B
Ruby
# frozen_string_literal: true
|
|
|
|
require "rake/testtask"
|
|
|
|
test_files = FileList["test/**/*_test.rb"]
|
|
|
|
desc "Default Task"
|
|
task default: :test
|
|
|
|
task :package
|
|
|
|
# Run the unit tests
|
|
Rake::TestTask.new do |t|
|
|
t.libs << "test"
|
|
t.test_files = test_files
|
|
|
|
t.warning = true
|
|
t.verbose = true
|
|
t.ruby_opts = ["--dev"] if defined?(JRUBY_VERSION)
|
|
end
|
|
|
|
namespace :test do
|
|
task :isolated do
|
|
test_files.all? do |file|
|
|
sh(Gem.ruby, "-w", "-Ilib:test", file)
|
|
end || raise("Failures")
|
|
end
|
|
end
|
|
|
|
task :lines do
|
|
load File.expand_path("../tools/line_statistics", __dir__)
|
|
files = FileList["lib/**/*.rb"]
|
|
CodeTools::LineStatistics.new(files).print_loc
|
|
end
|
|
|
|
rule ".rb" => ".y" do |t|
|
|
sh "racc -l -o #{t.name} #{t.source}"
|
|
end
|
|
|
|
task compile: "lib/action_dispatch/journey/parser.rb"
|