mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
1f80e8d685
This broke natural order of things for `StaleSessionCheck#stale_session_check!` which tried auto_loading a class based on `ArgumentError` message , and later retrying the `Marshal#load` of class, successfully allowing auto_loading. This PR tries to fix this behavior by forwarding `ArgumentError` 's not raised by `Base64.strict_decode64` , as is, ahead to `StaleSessionCheck#stale_session_check!`
79 lines
2.4 KiB
Ruby
79 lines
2.4 KiB
Ruby
require 'abstract_unit'
|
|
|
|
begin
|
|
require 'openssl'
|
|
OpenSSL::Digest::SHA1
|
|
rescue LoadError, NameError
|
|
$stderr.puts "Skipping MessageVerifier test: broken OpenSSL install"
|
|
else
|
|
|
|
require 'active_support/time'
|
|
require 'active_support/json'
|
|
|
|
class MessageVerifierTest < ActiveSupport::TestCase
|
|
|
|
class JSONSerializer
|
|
def dump(value)
|
|
ActiveSupport::JSON.encode(value)
|
|
end
|
|
|
|
def load(value)
|
|
ActiveSupport::JSON.decode(value)
|
|
end
|
|
end
|
|
|
|
def setup
|
|
@verifier = ActiveSupport::MessageVerifier.new("Hey, I'm a secret!")
|
|
@data = { :some => "data", :now => Time.local(2010) }
|
|
end
|
|
|
|
def test_simple_round_tripping
|
|
message = @verifier.generate(@data)
|
|
assert_equal @data, @verifier.verify(message)
|
|
end
|
|
|
|
def test_missing_signature_raises
|
|
assert_not_verified(nil)
|
|
assert_not_verified("")
|
|
end
|
|
|
|
def test_tampered_data_raises
|
|
data, hash = @verifier.generate(@data).split("--")
|
|
assert_not_verified("#{data.reverse}--#{hash}")
|
|
assert_not_verified("#{data}--#{hash.reverse}")
|
|
assert_not_verified("purejunk")
|
|
end
|
|
|
|
def test_alternative_serialization_method
|
|
prev = ActiveSupport.use_standard_json_time_format
|
|
ActiveSupport.use_standard_json_time_format = true
|
|
verifier = ActiveSupport::MessageVerifier.new("Hey, I'm a secret!", :serializer => JSONSerializer.new)
|
|
message = verifier.generate({ :foo => 123, 'bar' => Time.utc(2010) })
|
|
exp = { "foo" => 123, "bar" => "2010-01-01T00:00:00.000Z" }
|
|
assert_equal exp, verifier.verify(message)
|
|
ensure
|
|
ActiveSupport.use_standard_json_time_format = prev
|
|
end
|
|
|
|
def test_raise_error_when_argument_class_is_not_loaded
|
|
# To generate the valid message below:
|
|
#
|
|
# AutoloadClass = Struct.new(:foo)
|
|
# valid_message = @verifier.generate(foo: AutoloadClass.new('foo'))
|
|
#
|
|
valid_message = "BAh7BjoIZm9vbzonTWVzc2FnZVZlcmlmaWVyVGVzdDo6QXV0b2xvYWRDbGFzcwY6CUBmb29JIghmb28GOgZFVA==--f3ef39a5241c365083770566dc7a9eb5d6ace914"
|
|
exception = assert_raise(ArgumentError, NameError) do
|
|
@verifier.verify(valid_message)
|
|
end
|
|
assert_includes ["uninitialized constant MessageVerifierTest::AutoloadClass",
|
|
"undefined class/module MessageVerifierTest::AutoloadClass"], exception.message
|
|
end
|
|
|
|
def assert_not_verified(message)
|
|
assert_raise(ActiveSupport::MessageVerifier::InvalidSignature) do
|
|
@verifier.verify(message)
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|