1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/actionpack/test/journey
Daniel Colson 8eec6ee962
Move Path::Pattern factories into test helper
`Pattern#from_sting` was introduced in bb207ea7 to support creating
patterns from strings in tests (removing a conditional in the initialize
method that had been there only for the sake of those tests).

`Pattern#build` was introduced in 947ebe9a, and was similarly used only
in tests.

My understanding is that [`Mapping#path`][path] is the only place where
we initialize a `Path::Pattern` in library code.

Since these two methods appear to be used only in tests, this
commit moves them out of the class and into a test helper.

My reasoning for doing this is that I am doing some performance work
that may involve a modification to how `Path::Pattern`s get initialized,
and I will have more confidence in that work if I know for sure that
these methods are test helpers that can be modified freely.

[path]: https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/routing/mapper.rb#L192-L194
2020-07-27 12:23:33 -04:00
..
gtg Remove unused journey code 2020-04-25 00:40:37 +09:00
nodes Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
path Move Path::Pattern factories into test helper 2020-07-27 12:23:33 -04:00
route/definition Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
router Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
route_test.rb Move Path::Pattern factories into test helper 2020-07-27 12:23:33 -04:00
router_test.rb Convert route params array into object 2020-06-05 13:18:49 -04:00
routes_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00